Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c zend_globals.h zend_unicode.c

2006-10-05 Thread Andrei Zmievski
Interesting. http://icu.sourceforge.net/apiref/icu4c/ uclean_8h.html#93f27d0ddc7c196a1da864763f2d8920 Perhaps we should not call u_cleanup() at all.. -Andrei On Oct 4, 2006, at 1:42 PM, Rob Richards wrote: That does prevent the crash. I did find that within zend_shutdown, if I comment out

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c zend_globals.h zend_unicode.c

2006-10-04 Thread Rob Richards
That does prevent the crash. I did find that within zend_shutdown, if I comment out the call to u_cleanup(), then ucol_close doesn't crash within unicode_globals_dtor during tsrm_shutdown. If that helps any. Rob Andrei Zmievski wrote: I suppose we can omit the ucol_close() call since we're s

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c zend_globals.h zend_unicode.c

2006-10-04 Thread Andrei Zmievski
I suppose we can omit the ucol_close() call since we're shutting down completely and ICU will close all resources anyway on exit, I believe. -Andrei On Oct 4, 2006, at 6:28 AM, Rob Richards wrote: Seems to be a windows only problem for me. Works fine under linux, but I've tried 3 different

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c zend_globals.h zend_unicode.c

2006-10-04 Thread Rob Richards
Seems to be a windows only problem for me. Works fine under linux, but I've tried 3 different builds of the ICU library - even built one from source - and it always crashes at the same point within the ucol_close call. Rob Andrei Zmievski wrote: Strange. I don't see it here on FreeBSD. Does an

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

2005-08-16 Thread Marcus Boerger
Hello Andrei, if unicode is enabled we could handle all property/class and function names as unicode internally and as native strings if unicode is disabled. However that would be a slowdown, so i asked which is better, ease of coding or speed. Anyway i'd like to have property keys always be sto

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

2004-06-01 Thread Rasmus Lerdorf
I'd like to see this in PHP4 too. -Rasmus On Tue, 1 Jun 2004, Andrei Zmievski wrote: > Should we add this to PHP 4 as well? > > On Tue, 01 Jun 2004, Andi Gutmans wrote: > > andiTue Jun 1 07:45:46 2004 EDT > > > > Modified files: > > /ZendEngine2zend.c

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

2003-12-19 Thread Andi Gutmans
At 12:54 AM 12/20/2003 +0900, Moriyoshi Koizumi wrote: On 2003/12/20, at 0:21, Dmitry Stogov wrote: Hi Moriyoshi, Yes I am sure. Andi approved this patch today. I didn't know about your patch. May be you know some situations when my patch will not work properly? As far as I looked over the patc

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

2003-06-08 Thread Sebastian Bergmann
Zeev Suraski wrote: > Was it crashing under a specific script, or always? Always since the "MEGA-patch: namespaces are R.I.P.". -- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ http://www.professionelle-softwareentwicklung-mit-php5.de/

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

2003-06-08 Thread Sebastian Bergmann
Zeev Suraski wrote: > When was it crashing, prior to that fix? zend.c:1.231 segfaulted. In zend.c:1.232 I "fixed" the segfault, or what fix did you mean? -- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ http://www.professionelle-soft

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

2003-06-08 Thread Zeev Suraski
At 23:00 05/06/2003, Sebastian Bergmann wrote: Zeev Suraski wrote: > It does look like a voodoo fix. What's crashing exactly? Zeev, Stanislav already looked into this and the segfault related to GLOBAL_CONSTANTS_TABLE not beeing malloc()ed in ZTS mode is now gone. But with a fairly odd fix.

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

2003-06-05 Thread Edin Kadribasic
On Wed, 4 Jun 2003, Sebastian Bergmann wrote: > Marcus Börger wrote: > > So he should be forgiven if he doesn't try all version. > > Marcus, Derick, *, > > relax. Don't "defend" me, as I feel not "offended". For the first time > I did not test a non-ZTS build before committing a ZTS fix, s

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c

2003-06-05 Thread Marcus Börger
At 15:43 04.06.2003, Sebastian Bergmann wrote: Thies C. Arntzen wrote: > i trust you;-) but - after looking thru zend.c - i think that > the TLS stuff is getting more and more un-maintainable. What really looks messed up is #ifdef ZTS ... #ifdef ZTS ... #else ... #end