Re: [PHP-DEV] Re: [VOTE] Object-based token_get_all() alternative

2020-03-25 Thread Alexander Lisachenko
Hello, internals team! I would like to propose to rename the PhpToken::getAll() method into the PhpToken::tokenize(string $source) or PhpToken::lex(string $source) to use a more meaningful verb word. After renaming, it will sound more natural: $tokenStream = PhpToken::tokenize($sourceCode) Best

Re: [PHP-DEV] Re: [VOTE] Object-based token_get_all() alternative

2020-03-23 Thread Larry Garfield
On Mon, Mar 23, 2020, at 9:07 AM, Nikita Popov wrote: > On Fri, Mar 6, 2020 at 10:33 AM Nikita Popov wrote: > > > Hi internals, > > > > I've opened voting on https://wiki.php.net/rfc/token_as_object, which > > adds a new object-based interface to the tokenizer. Voting closes on > > 2020-03-20. >