Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2015-01-11 Thread Sebastian Bergmann
Am 11.01.2015 um 09:03 schrieb Ferenc Kovacs: > There is https://github.com/nikic/php-ast Aha! Thanks for the pointer, Ferenc. Can we get this bundled with PHP 7 (and enabled by default)? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.ph

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2015-01-11 Thread Ferenc Kovacs
2015.01.11. 7:55 ezt írta ("Sebastian Bergmann" ): > > Am 25.08.2014 um 19:39 schrieb Nikita Popov: > > I don't know if I will be implementing that ext myself. In any case, before > > that can happen I will have to create another RFC for converting parse > > errors into exceptions and making sure w

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2015-01-10 Thread Sebastian Bergmann
Am 25.08.2014 um 19:39 schrieb Nikita Popov: > I don't know if I will be implementing that ext myself. In any case, before > that can happen I will have to create another RFC for converting parse > errors into exceptions and making sure we don't leak memory on failed parse > - I think thats a prere

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-27 Thread Matt Ficken
I get no new test failures on master after AST merged. Before and after the AST merge, I still get ~200 tests failing on Windows. My test runs turned up a few crashes, which I am reproducing to get BTs to share. I'm not sure if the crashes are AST related. On Tue, Aug 26, 2014 at 2:50 AM, Fer

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-26 Thread Ferenc Kovacs
On Tue, Aug 26, 2014 at 1:58 AM, Andrea Faulds wrote: > > On 26 Aug 2014, at 00:53, Benjamin Eberlei wrote: > > > Depends, registering for shutdown handlers and catching fatals is a > pretty > > common thing. If EngineException does not get caught, it should produce > an > > E_FATAL again with t

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-25 Thread Andrea Faulds
On 26 Aug 2014, at 00:53, Benjamin Eberlei wrote: > Depends, registering for shutdown handlers and catching fatals is a pretty > common thing. If EngineException does not get caught, it should produce an > E_FATAL again with the correct error code. Exceptions already do this, do they not? I don

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-25 Thread Benjamin Eberlei
On Tue, Aug 26, 2014 at 1:12 AM, Stas Malyshev wrote: > Hi! > > > This is something that Nikita had originally proposed in an RFC > > (https://wiki.php.net/rfc/engine_exceptions) but postponed until after > 5.6. > > > > I have a feeling we'll be hearing about its resurrection soon enough. > > 5.6

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-25 Thread Stas Malyshev
Hi! > This is something that Nikita had originally proposed in an RFC > (https://wiki.php.net/rfc/engine_exceptions) but postponed until after 5.6. > > I have a feeling we'll be hearing about its resurrection soon enough. 5.6 was not a good place for it, but PHP 7 very well may be. Some cleanup

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-25 Thread Nikita Popov
On Mon, Aug 25, 2014 at 11:39 PM, Stas Malyshev wrote: > Hi! > > > I don't know if I will be implementing that ext myself. In any case, > before > > that can happen I will have to create another RFC for converting parse > > errors into exceptions and making sure we don't leak memory on failed > p

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-25 Thread Trevor Suarez
> > If we're talking the plunge of putting exceptions into the core engine, > wouldn't it make sense to convert most of the fatal errors (especially > the "catchable" ones) to exceptions too? Most of them (except for out of > memory, timeouts and such) don't really require the engine to shut down,

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-25 Thread Stas Malyshev
Hi! > I don't know if I will be implementing that ext myself. In any case, before > that can happen I will have to create another RFC for converting parse > errors into exceptions and making sure we don't leak memory on failed parse If we're talking the plunge of putting exceptions into the core

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-25 Thread Nikita Popov
On Mon, Aug 25, 2014 at 7:07 PM, Sebastian Bergmann wrote: > Am 25.08.2014 um 19:01 schrieb Nikita Popov: > > The Abstract Syntax Tree RFC has been accepted unanimously, with 47 > > votes in favor and 0 against. > > Yay! :-) Thank you for your work, Nikita. > > > I'll merge the patch as soon as t

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-25 Thread Sebastian Bergmann
Am 25.08.2014 um 19:01 schrieb Nikita Popov: > The Abstract Syntax Tree RFC has been accepted unanimously, with 47 > votes in favor and 0 against. Yay! :-) Thank you for your work, Nikita. > I'll merge the patch as soon as the int64 naming issues are resolved. Do you when you'll get around to i