Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

Hi Kalle! On 04.05.2019 at 13:33, Kalle Sommer Nielsen wrote: > Den lør. 4. maj 2019 kl. 14.19 skrev Christoph M. Becker : >> >> On 04.05.2019 at 10:56, Christoph M. Becker wrote: >> >>> I have submitted PR #4112 to bring back the common PDO tests, which are >>> the majority of existing tests for

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

Hi Christoph Den lør. 4. maj 2019 kl. 14.19 skrev Christoph M. Becker : > > On 04.05.2019 at 10:56, Christoph M. Becker wrote: > > > I have submitted PR #4112 to bring back the common PDO tests, which are > > the majority of existing tests for pdo_firebird. Three tests are > > failing (which shou

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On 04.05.2019 at 10:56, Christoph M. Becker wrote: > I have submitted PR #4112 to bring back the common PDO tests, which are > the majority of existing tests for pdo_firebird. Three tests are > failing (which should be investigated), but these tests already failed > in PHP-7.3 and maybe before.

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

Hi Kalle! On 03.05.2019 at 19:00, Kalle Sommer Nielsen wrote: > Den fre. 3. maj 2019 kl. 12.02 skrev Christoph M. Becker : > >> While running the tests with a PHP debug version, I've noticed that >> bug_aaa.phpt is causing a memory leak. Maybe someone proficient with >> Firebird/Interbase will w

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

Hi Christoph Den fre. 3. maj 2019 kl. 12.02 skrev Christoph M. Becker : > While running the tests with a PHP debug version, I've noticed that > bug_aaa.phpt is causing a memory leak. Maybe someone proficient with > Firebird/Interbase will want to have a look at it. Thank you for testing, good to

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On 02.05.2019 at 22:21, Kalle Sommer Nielsen wrote: > Den tor. 2. maj 2019 kl. 22.55 skrev Lester : >> The problem with including a database is it's dependent on the version >> of FB running. This will only run with FB3 while FB2.x is still in >> common use hence it being preferable to use somethi

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

Hi Den tor. 2. maj 2019 kl. 22.55 skrev Lester : > The problem with including a database is it's dependent on the version > of FB running. This will only run with FB3 while FB2.x is still in > common use hence it being preferable to use something supplied with the > FB installation. > > https://fi

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On 02/05/2019 19:51, Kalle Sommer Nielsen wrote: It also includes a 'php.fdb', which I'm not certain whether or not we should keep as its quite large, but at least it makes the tests run for me with 15/15 pass. The problem with including a database is it's dependent on the version of FB runnin

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On 02/05/2019 18:58, Christoph M. Becker wrote: Glancing that the ext/pgsql and ext/pdo_pgsql tests, though, it looks like we just require the user to have run "createdb test" before running the test suite. Indeed, see . htt

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On 02.05.2019 at 18:58, Rowan Collins wrote: > On Thu, 2 May 2019 at 14:57, Christoph M. Becker wrote: > >> Indeed, it seems that pdo_firebird requires to connect to an existing >> database, contrary to e.g. pdo_mysql which supports DSN like >> `mysql:host=localhost`, to my knowledge. > > Postgre

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On Thu, 2 May 2019 at 14:57, Christoph M. Becker wrote: > Indeed, it seems that pdo_firebird requires to connect to an existing > database, contrary to e.g. pdo_mysql which supports DSN like > `mysql:host=localhost`, to my knowledge. > Postgres works the same way - a connection is always to a s

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On 02/05/2019 15:24, Christoph M. Becker wrote: A patch would be welcome! Looks like every file needs modifying ... I'll see what I can do, but my local php-src is broken and will not sync currently :( -- Lester Caine - G8HFL - Contact - https://lsces.co.uk/wiki/?p

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On 02.05.2019 at 16:04, Lester wrote: > On 02/05/2019 14:35, Kalle Sommer Nielsen wrote: > >> Yeah that is one thing that is kind of unfortunate and a bad practice. >> However since interbase was disabled for AppVeyor, these tests had no >> chance to run in a while. Looking at the actual code in t

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On 02/05/2019 14:35, Kalle Sommer Nielsen wrote: Hi Christoph Den tor. 2. maj 2019 kl. 14.56 skrev Christoph M. Becker : A problem is that the ext/pdo_firebird tests rely on ext/interbase to create a test database[1], which would require everybody who intends to run these tests to install PECL/

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

Hi Martin, On Mon, Apr 15, 2019, 5:08 PM Nikita Popov wrote: > On Mon, Apr 15, 2019 at 11:51 AM Köditz, Martin > wrote: > > > Hello everybody, > > > > I want to give you the general state of the Firebird driver. At the end > of > > January, I agreed to continue developing the Firebird driver as

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

Hi Martin, On Mon, 15 Apr 2019 at 10:50, Köditz, Martin wrote: > I agreed to continue developing the Firebird driver as a maintainer. As mentioned previously, possibly the first thing you should do is to make clear if you're maintaining it as something that is compatible with Firebird, or wheth

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On Mon, Apr 15, 2019 at 12:17 PM Köditz, Martin wrote: > Hi Nikita, > > > To update the documentation you can either use the editor at > edit.php.net (useful for smaller changes and does not require > permissions), > > or also request direct commit access to the documentation. > I've added the ch

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On Mon, Apr 15, 2019 at 11:51 AM Köditz, Martin wrote: > Hello everybody, > > I want to give you the general state of the Firebird driver. At the end of > January, I agreed to continue developing the Firebird driver as a > maintainer. In this regard, I first took care of getting familiar with the

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

Hi Kalle, You forgot to move to voting on the RFC index. Cheers Joe On Tue, 9 Apr 2019, 19:07 Kalle Sommer Nielsen, wrote: > Den tir. 9. apr. 2019 kl. 20.02 skrev Kalle Sommer Nielsen >: > > > > Evening Internals > > > > Apologies for the one day delay, but the voting for the RFC "Unbundle >