Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-26 Thread Theodore Brown
On Mon, May 26, 2025 at 08:03 Volker Dusch wrote:   > Version 1.1 Update: Array syntax over named arguments. > > Thank you everyone for the discussion and for improving this RFC. > I'm very happy with the updates we made thanks to your feedback on and off > list. > > The main idea of this RFC wa

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-26 Thread Tim Düsterhus
Hi Clarifying on the technical questions. Am 2025-05-26 16:37, schrieb Nicolas Grekas: I think the RFC is missing a few bits to be complete: - making "clone" a function means suddenly a "use clone;" or a "\clone" is going to be needed to not get a perf hit, isn't it? But since $y = clone $x

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-26 Thread Nicolas Grekas
Hi Volker, Thanks for the update. Le lun. 26 mai 2025 à 16:05, Volker Dusch a écrit : > Version 1.1 Update: Array syntax over named arguments. > > Thank you everyone for the discussion and for improving this RFC. I'm very > happy with the updates we made thanks to your feedback on and off list.

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-22 Thread Theodore Brown
On Wed, May 21, 2025 at 23:27 Larry Garfield wrote: > On Wed, May 21, 2025, at 9:13 AM, Tim Düsterhus wrote: >> Am 2025-05-19 12:48, schrieb Volker Dusch: >>> We're still looking for feedback on the ...variadic approach to the >>> Syntax: >>> https://wiki.php.net/rfc/clone_with_v2#open_issues, as w

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-21 Thread Larry Garfield
On Wed, May 21, 2025, at 9:13 AM, Tim Düsterhus wrote: > Hi > > Am 2025-05-19 12:48, schrieb Volker Dusch: >> We're still looking for feedback on the ...variadic approach to the >> Syntax: >> https://wiki.php.net/rfc/clone_with_v2#open_issues, as we only got one >> reply so far on the topic. > > I

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-21 Thread Tim Düsterhus
Hi Am 2025-05-21 17:27, schrieb Theodore Brown: Combining named-parameter `array()` syntax with clone taking a array as the second parameter would allow for the following, which might combine the best of both worlds? clone($obj, array(foo: 1, bar: "baz", object: "this is not blocked"));

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-21 Thread Theodore Brown
On Wed, May 21, 2025 at 09:13 Tim Düsterhus wrote: > Am 2025-05-19 12:48, schrieb Volker Dusch: >> We're still looking for feedback on the ...variadic approach to the >> Syntax: >> https://wiki.php.net/rfc/clone_with_v2#open_issues, as we only got one >> reply so far on the topic. > > ... > > *So

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-21 Thread Tim Düsterhus
Hi Am 2025-05-21 16:27, schrieb Nicolas Grekas: Thanks for sharing your insights. This looks a bit far reaching for the RFC. Making `array()` a function / allowing named parameter syntax with `array()` would be a separate RFC. On my side, my opinion is: don't make clone a function call. I'

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-21 Thread Tim Düsterhus
Hi Am 2025-05-19 12:48, schrieb Volker Dusch: We're still looking for feedback on the ...variadic approach to the Syntax: https://wiki.php.net/rfc/clone_with_v2#open_issues, as we only got one reply so far on the topic. I was hoping for some additional opinions here before adding my own, but

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-21 Thread Nicolas Grekas
Hi Tim, Le mer. 21 mai 2025 à 16:15, Tim Düsterhus a écrit : > Hi > > Am 2025-05-19 12:48, schrieb Volker Dusch: > > We're still looking for feedback on the ...variadic approach to the > > Syntax: > > https://wiki.php.net/rfc/clone_with_v2#open_issues, as we only got one > > reply so far on the

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-21 Thread Tim Düsterhus
Hi Am 2025-05-19 15:30, schrieb Larry Garfield: For positional parameters, I don't see any way that they'd work or do what someone expects. So why not just block them entirely instead of relying on dynamic properties to warn-but-sorta-work? For better or worse PHP supports numeric properties

Re: [PHP-DEV] Re: [RFC] Clone with v2

2025-05-19 Thread Larry Garfield
On Mon, May 19, 2025, at 5:48 AM, Volker Dusch wrote: > Hey everyone, > > Thank you for the participation so far, since the start of the > discussion, from feedback on and off list, I've added a couple of > examples: > > - > https://wiki.php.net/rfc/clone_with_v2#:~:text=dynamic%20property%20cre