Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-07-10 Thread Tim Düsterhus
Hi I'm specifically replying to Nicolas, but this email is directed to the general public, so please feel free to reply even if you are not called Nicolas :-) On 6/24/24 17:06, Nicolas Grekas wrote: 2/ About the "since" parameter, we're going to standardize around a package+version string,

Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-06-27 Thread Tim Düsterhus
Hi On 6/27/24 13:10, Nicolas Grekas wrote: That's sad news, because I keep explaining why engine-triggered runtime notices are a terrible idea, yet you're planning to add more of them. The consistency argument Tim wrote in another email isn't sound to me: consistency with a bad idea doesn't make

Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-06-27 Thread Nicolas Grekas
Le mar. 25 juin 2024 à 22:01, Benjamin Außenhofer a écrit : > > > On Mon, Jun 24, 2024 at 5:07 PM Nicolas Grekas < > nicolas.grekas+...@gmail.com> wrote: > >> >> >> Le mer. 5 juin 2024 à 10:18, Benjamin Außenhofer a >> écrit : >> >>> >>> >>> On Wed, May 22, 2024 at 9:22 AM Benjamin Außenhofer >

Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-06-25 Thread Benjamin Außenhofer
On Mon, Jun 24, 2024 at 5:07 PM Nicolas Grekas wrote: > > > Le mer. 5 juin 2024 à 10:18, Benjamin Außenhofer a > écrit : > >> >> >> On Wed, May 22, 2024 at 9:22 AM Benjamin Außenhofer >> wrote: >> >>> The vote for the RFC #[\Deprecated] attribute is now open: >>> >>> https://wiki.php.net/rfc/de

Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-06-25 Thread Tim Düsterhus
Hi On 6/24/24 17:06, Nicolas Grekas wrote: Since the vote passed, we're discussing how we might use the attribute in Symfony. 2 things on the topic: 1/ We're wondering about using it at the class level despite the missing Attribute::TARGET_CLASS. ReflectionAttribute does allow reading attribute

Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-06-24 Thread Matthew Weier O'Phinney
On Mon, Jun 24, 2024, 7:35 PM Stephen Reay wrote: > > Sent from my iPhone > > On 24 Jun 2024, at 23:43, Matthew Weier O'Phinney < > mweierophin...@gmail.com> wrote: > >  > > > On Mon, Jun 24, 2024 at 10:08 AM Nicolas Grekas < > nicolas.grekas+...@gmail.com> wrote: > >> >> >> Le mer. 5 juin 2024

Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-06-24 Thread Stephen Reay
Sent from my iPhoneOn 24 Jun 2024, at 23:43, Matthew Weier O'Phinney wrote:On Mon, Jun 24, 2024 at 10:08 AM Nicolas Grekas wrote:Le mer. 5 juin 2024 à 10:18, Benjamin Außenhofer a écrit :On Wed, May 22, 2024 at 9:22 AM Benjamin Außenhofer

Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-06-24 Thread Matthew Weier O'Phinney
On Mon, Jun 24, 2024 at 10:08 AM Nicolas Grekas < nicolas.grekas+...@gmail.com> wrote: > > > Le mer. 5 juin 2024 à 10:18, Benjamin Außenhofer a > écrit : > >> >> >> On Wed, May 22, 2024 at 9:22 AM Benjamin Außenhofer >> wrote: >> >>> The vote for the RFC #[\Deprecated] attribute is now open: >>>

Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-06-24 Thread Nicolas Grekas
Le mer. 5 juin 2024 à 10:18, Benjamin Außenhofer a écrit : > > > On Wed, May 22, 2024 at 9:22 AM Benjamin Außenhofer > wrote: > >> The vote for the RFC #[\Deprecated] attribute is now open: >> >> https://wiki.php.net/rfc/deprecated_attribute >> >> Voting will close on Wednesday 5th June, 08:00 G

Re: [PHP-DEV] Re: [RFC] [Vote] #[\Deprecated] attribute

2024-06-10 Thread Tim Düsterhus
Hi On 6/5/24 10:16, Benjamin Außenhofer wrote: Tim will finalize the implementation PR now and work on its merge in the upcoming days. During review Ilija pointed out that adding the internal ZEND_ACC_DEPRECATED flag was skipped for abstract methods and interface methods, questioning the de