Re: [PHP-DEV] Re: [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-24 Thread Stephen Reay
> On 24 Jun 2022, at 22:45, Dan Ackroyd wrote: > > Larry Garfield wrote: > >> "Create all DB sub-classes?" - I'd say they all should have subclasses, even >> if empty. It's more consistent* that way, and you can then also rely on >> instanceof giving you useful information rather than "well,

Re: [PHP-DEV] Re: [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-24 Thread Rowan Tommins
On Fri, 24 Jun 2022 at 16:38, Dan Ackroyd wrote: > YAGNI, and I'm lazy. But mostly, I don't think adding them now > actually helps achieve anything. > Fair enough, but as a minimum there should be an internal API for registering a sub-class, without any modification to ext/pdo. For instance, i

Re: [PHP-DEV] Re: [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-24 Thread Dan Ackroyd
Larry Garfield wrote: > "Create all DB sub-classes?" - I'd say they all should have subclasses, even > if empty. It's more consistent* that way, and you can then also rely on > instanceof giving you useful information rather than "well, it's not one of > the special ones, so beyond that, NFI." Y