Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-12-08 Thread Ilija Tovilo
Hi Sam >> On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo wrote: >> > https://wiki.php.net/rfc/rfc1867-non-post On Thu, Dec 7, 2023 at 6:04 PM Sam I wrote: > > Hey, I'm not sure if this is bikeshedding, but the concept of parsing bodies > for non-POST requests lands really close to a proposal for a

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-12-07 Thread Sam I
Hey, I'm not sure if this is bikeshedding, but the concept of parsing bodies for non-POST requests lands really close to a proposal for adding a QUERY method to the HTTP standard. Draft: https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-safe-method-w-body Discussion: https://github.com/httpw

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-31 Thread Ilija Tovilo
Hi Derick On Wed, Oct 18, 2023 at 6:10 PM Derick Rethans wrote: > On Fri, 13 Oct 2023, Ilija Tovilo wrote: > > > https://wiki.php.net/rfc/rfc1867-non-post > > The only comment I would have is that I probably would be in favour of > not leaving the "config" argument (to over ride per call the > po

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-19 Thread Larry Garfield
On Thu, Oct 19, 2023, at 11:26 AM, Ilija Tovilo wrote: >> 2. Lots of request bodies are not forms these days; they're frequently JSON >> or GraphQL. This function would be useless in those cases; that's fine, but >> should the name then suggest that it's for form data only? >> request_parse_f

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-19 Thread Ilija Tovilo
Hi Larry On Wed, Oct 18, 2023 at 7:26 PM Larry Garfield wrote: > > On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo wrote: > >> https://wiki.php.net/rfc/rfc1867-non-post > > The functionality all seems reasonable to me. I have a few smaller concerns: > > 1. Like Derick, I think I'd favor including t

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-18 Thread Larry Garfield
On Fri, Oct 13, 2023, at 11:15 AM, Ilija Tovilo wrote: > Hi everyone > > On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo wrote: >> https://wiki.php.net/rfc/rfc1867-non-post > > Thank you for the feedback so far. I made a handful of changes to the RFC. > > * The function is renamed to request_parse_bod

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-18 Thread Derick Rethans
On Fri, 13 Oct 2023, Ilija Tovilo wrote: > On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo wrote: > > https://wiki.php.net/rfc/rfc1867-non-post > > Thank you for the feedback so far. I made a handful of changes to the RFC. … > Let me know if you have any more feedback. The only comment I would ha

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-13 Thread Tim Düsterhus
Hi On 10/13/23 17:59, Michał Marcin Brzuchalski wrote: Considering the function supports two formats multipart/form-data or the application/x-www-form-urlencodedand the fact that the return type and required arguments differ in regards to format: content-type needed for multipart which returns t

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-13 Thread Michał Marcin Brzuchalski
Hi Ilija, pt., 13 paź 2023, 13:15 użytkownik Ilija Tovilo napisał: > Hi everyone > > On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo > wrote: > > https://wiki.php.net/rfc/rfc1867-non-post > > Thank you for the feedback so far. I made a handful of changes to the RFC. > > * The function is renamed to