Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/snmp php_snmp.hsnmp.c

2003-06-23 Thread Derick Rethans
On Sun, 22 Jun 2003, Rasmus Lerdorf wrote: > On Sun, 22 Jun 2003, Johann Hanne wrote: > > The point is that with valueretrieval set to 0, the SNMP value is still > > retrieved with snprint_value()/sprint_value(). I've been really really > > careful with this... > > > > Of course the statement "The

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/snmp php_snmp.hsnmp.c

2003-06-22 Thread Rasmus Lerdorf
On Sun, 22 Jun 2003, Johann Hanne wrote: > The point is that with valueretrieval set to 0, the SNMP value is still > retrieved with snprint_value()/sprint_value(). I've been really really > careful with this... > > Of course the statement "The way SNMP values are retrieved has been > changed" isn'

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/snmp php_snmp.hsnmp.c

2003-06-22 Thread Rasmus Lerdorf
Johann, the problem is that it looks like it might break backward compatibility with some scripts. People don't expect their scripts to break in a minor PHP version upgrade. Your php_snmp_getvalue() function creates either a string or an object which is then returned elsewhere whereas previously

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/snmp php_snmp.hsnmp.c

2003-06-22 Thread Derick Rethans
On Sun, 22 Jun 2003, Sascha Schumann wrote: > > The last one is the ONLY thing where existing code is modified, and I've > > really tested it extensively. So where's the problem??? > > There is no problem. Can you or Harrie make sure that the > patch gets applied to head, so that the bra

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/snmp php_snmp.hsnmp.c

2003-06-22 Thread Sascha Schumann
> The last one is the ONLY thing where existing code is modified, and I've > really tested it extensively. So where's the problem??? There is no problem. Can you or Harrie make sure that the patch gets applied to head, so that the branches are in sync? - Sascha -- PHP Internals - P

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/snmp php_snmp.hsnmp.c

2003-06-22 Thread Derick Rethans
On Sun, 22 Jun 2003, Johann Hanne wrote: > I can't believe it. I posted this patch several times. Everybody but Harrie > ignored it. I even wrote that I hope it gets into 4.3.3. Nobody except Harrie > replied. Now it's applied and NOW somebody has to claim it's a huge feature > patch which shou