Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/pcre TODO

2006-04-10 Thread Andrei Zmievski
On Apr 9, 2006, at 6:31 AM, Derick Rethans wrote: We should only do that is the regexp is the *only* parameter that can make pcre_exec fail. If the subject string can influence this we should not show a warning as you'd have to silence that by hand then. But subject string and pattern work han

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/pcre TODO

2006-04-09 Thread Nuno Lopes
On Sun, 9 Apr 2006, Nuno Lopes wrote: OK, I've made a patch for you: http://mega.ist.utl.pt/~ncpl/php_pcre_match_limit.txt adds: pcre.match_limit and pcre.match_limit_recursion. BTW, I think we should print a warning when pcre_exec() fails. Currently we just fail silently. We should only do

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/pcre TODO

2006-04-09 Thread Derick Rethans
On Sun, 9 Apr 2006, Nuno Lopes wrote: > OK, I've made a patch for you: > http://mega.ist.utl.pt/~ncpl/php_pcre_match_limit.txt > adds: pcre.match_limit and pcre.match_limit_recursion. > > BTW, I think we should print a warning when pcre_exec() fails. Currently we > just fail silently. We should

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/pcre TODO

2006-04-09 Thread Nuno Lopes
OK, I've made a patch for you: http://mega.ist.utl.pt/~ncpl/php_pcre_match_limit.txt adds: pcre.match_limit and pcre.match_limit_recursion. BTW, I think we should print a warning when pcre_exec() fails. Currently we just fail silently. Nuno - Original Message - I was just thinking

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/pcre TODO

2006-04-07 Thread Andrei Zmievski
I was just thinking of adding a couple of INI settings that scripts can use to set match and match recursion limits. -Andrei On Apr 7, 2006, at 9:36 AM, Nuno Lopes wrote: andrei Thu Apr 6 22:37:42 2006 UTC Modified files: /php-src/ext/pcre TODO Log: That is not the bug you're looking