Re: [PHP-DEV] Re: [PATCH] double to long conversion change

2009-06-03 Thread Matt Wilmas
Hi again, OK, I will go ahead and commit the patch + test updates in about 24 hours... - Matt - Original Message - From: "Matt Wilmas" Sent: Friday, May 29, 2009 Hi all, - Original Message - From: "Matt Wilmas" Sent: Friday, April 10, 2009 Hi Dmitry, I finally updated the

Re: [PHP-DEV] Re: [PATCH] double to long conversion change

2009-05-29 Thread Matt Wilmas
Hi all, - Original Message - From: "Matt Wilmas" Sent: Friday, April 10, 2009 Hi Dmitry, I finally updated the patches: http://realplain.com/php/dval_to_lval.diff http://realplain.com/php/dval_to_lval_5_3.diff The patches were updated again, against current CVS (no changes by me). A

Re: [PHP-DEV] Re: [PATCH] double to long conversion change

2009-04-22 Thread Stanislav Malyshev
Hi! Really, I don't understand what it's going to fix (the need of preserving low bits looks strange for me). From what I understand the idea of the patch is what we are doing if we try to convert double that's too big for long into long (please correct me if I'm talking nonsense here). We'd

Re: [PHP-DEV] Re: [PATCH] double to long conversion change

2009-04-22 Thread Dmitry Stogov
I looked into it some time ago. Really, I don't understand what it's going to fix (the need of preserving low bits looks strange for me). Also it breaks ~30 tests. Thanks. Dmitry. Johannes Schlüter wrote: On Fri, 2009-04-10 at 14:45 -0500, Matt Wilmas wrote: Hi Dmitry, I finally updated the

Re: [PHP-DEV] Re: [PATCH] double to long conversion change

2009-04-21 Thread Johannes Schlüter
On Fri, 2009-04-10 at 14:45 -0500, Matt Wilmas wrote: > Hi Dmitry, > > I finally updated the patches: > http://realplain.com/php/dval_to_lval.diff > http://realplain.com/php/dval_to_lval_5_3.diff Has anybody (Dmitry?) reviewed this or other feedback? johannes -- PHP Internals - PHP Runtime D