Re: [PHP-DEV] Re: [DRAFT] [RFC] Function autoloading

2013-08-30 Thread Jordan DeLong
On Fri, Aug 30, 2013 at 03:21:47PM -0700, Stas Malyshev wrote: > Hi! > > > We got a performance win from exactly this at Facebook. We have some > > extensions in HHVM to autoload that allowed us to remove almost all > > our *_once calls. > > But autoloading does not remove require - you still ha

Re: [PHP-DEV] Re: [DRAFT] [RFC] Function autoloading

2013-08-30 Thread Sebastian Krebs
2013/8/31 Stas Malyshev > Hi! > > > We got a performance win from exactly this at Facebook. We have some > > extensions in HHVM to autoload that allowed us to remove almost all > > our *_once calls. > > But autoloading does not remove require - you still have to load the > files. But it remove

Re: [PHP-DEV] Re: [DRAFT] [RFC] Function autoloading

2013-08-30 Thread Stas Malyshev
Hi! > We got a performance win from exactly this at Facebook. We have some > extensions in HHVM to autoload that allowed us to remove almost all > our *_once calls. But autoloading does not remove require - you still have to load the files. Only thing that can be removed is a non-loading require

Re: [PHP-DEV] Re: [DRAFT] [RFC] Function autoloading

2013-08-30 Thread Jordan DeLong
On Fri, Aug 30, 2013 at 05:13:05PM +0100, Leigh wrote: > On Aug 30, 2013 1:31 PM, "Anthony Ferrara" wrote: > > For constants and function calls, the benchmark shows that the difference > > is well within the margin of error for the test (considering variances of > > 5% to 10% were common in my run

Re: [PHP-DEV] Re: [DRAFT] [RFC] Function autoloading

2013-08-30 Thread Leigh
On Aug 30, 2013 1:31 PM, "Anthony Ferrara" wrote: > For constants and function calls, the benchmark shows that the difference > is well within the margin of error for the test (considering variances of > 5% to 10% were common in my running of the tests). > > So hopefully this will dispel any worry

Re: [PHP-DEV] Re: [DRAFT] [RFC] Function autoloading

2013-08-30 Thread Laruence
On Sat, Aug 31, 2013 at 12:13 AM, Leigh wrote: > On Aug 30, 2013 1:31 PM, "Anthony Ferrara" wrote: >> For constants and function calls, the benchmark shows that the difference >> is well within the margin of error for the test (considering variances of >> 5% to 10% were common in my running of th

Re: [PHP-DEV] Re: [DRAFT] [RFC] Function autoloading

2013-08-30 Thread Nicolas Grekas
Hi The only regression can be where autoloaders are defined, and people are > relying on the legacy undefined constant behavior (which triggers an > E_NOTICE). > that makes me think about this code : What autoload should be triggered? "foo\bar" or "bar"? Both are valid isn't it? Should auto