Re: [PHP-DEV] RC3RC1

2004-05-30 Thread Andi Gutmans
Okay, I won't hold on in this case. I just want to resolve the return value to the user-error handler before I roll. I also understand that the proc_open() compile problems seem to be solved. Thanks, Andi At 04:13 PM 5/29/2004 -0400, Rob Richards wrote: From: Andi Gutmans > Please test. If there

Re: [PHP-DEV] RC3RC1

2004-05-29 Thread Rob Richards
From: Andi Gutmans > Please test. If there are no critical problems I'll release RC3 tomorrow > which I think will be the last RC for 5.0. Andi, hopefully you arent waiting on a fix for the libxml streams issue to roll RC3. I would suggest that our streams handling be left as is right now. I hav

Re: [PHP-DEV] RC3RC1

2004-05-28 Thread Daniel Fahlgren
On Fri, May 28, 2004 at 02:29:38PM +0100, Wez Furlong wrote: > Thanks; sorry for mailing twice, I got interrupted and forgot that I had > already asked you the question. > > Could you please test HEAD (or the next snapshot); I've updated it to what > will hopefully be the final incarnation of proc

Re: [PHP-DEV] RC3RC1

2004-05-28 Thread Curt Zirzow
* Thus wrote Wez Furlong ([EMAIL PROTECTED]): > Thanks; sorry for mailing twice, I got interrupted and forgot that I had > already asked you the question. > > Could you please test HEAD (or the next snapshot); I've updated it to what > will hopefully be the final incarnation of proc_open.c for PHP

RE: [PHP-DEV] RC3RC1

2004-05-28 Thread Wez Furlong
- > From: Daniel Fahlgren [mailto:[EMAIL PROTECTED] > Sent: 28 May 2004 14:21 > To: Wez Furlong > Cc: [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] RC3RC1 > > On Fri, May 28, 2004 at 01:25:36PM +0100, Wez Furlong wrote: > > Does IRIX also have grantpt() ? > > Yes. >

RE: [PHP-DEV] RC3RC1

2004-05-28 Thread Sascha Schumann
On Fri, 28 May 2004, Wez Furlong wrote: > A problem with that is that our php_config.h will unconditionally include > various system headers, not allowing an individual source file to set more > flags. You can tell PHP_ADD_SOURCES to use special compile flags for a specific compilation un

Re: [PHP-DEV] RC3RC1

2004-05-28 Thread Daniel Fahlgren
On Fri, May 28, 2004 at 01:25:36PM +0100, Wez Furlong wrote: > Does IRIX also have grantpt() ? Yes. > If so, what defines are needed to switch it on? Nothing but to include stdlib.h / Daniel Fahlgren -- I live the way I type; fast, with a lot of mistakes Daniel Fahlgren http://ww

Re: [PHP-DEV] RC3RC1

2004-05-28 Thread Daniel Fahlgren
Hello > Can you check if there is a guard for the grantpt function too? As long as you don't give the "-ansi" option to gcc it compiles without warning. All it needs it stdlib.h / Daniel Fahlgren -- I live the way I type; fast, with a lot of mistakes Daniel Fahlgren http://www.acc

RE: [PHP-DEV] RC3RC1

2004-05-28 Thread Wez Furlong
A problem with that is that our php_config.h will unconditionally include various system headers, not allowing an individual source file to set more flags. This is a problem, for example, on Solaris where defining the correct symbols to get Unix98 and the uint type working in turn causes stdio.h t

RE: [PHP-DEV] RC3RC1

2004-05-28 Thread Sascha Schumann
On Fri, 28 May 2004, Wez Furlong wrote: > These are all needed in different combinations on different systems. > Don't you just love standards!? It is extremely unwise to play with these flags, because there is nothing portable about them. Getting it right and making it work everywhe

RE: [PHP-DEV] RC3RC1

2004-05-28 Thread Wez Furlong
Does IRIX also have grantpt() ? If so, what defines are needed to switch it on? --Wez. > -Original Message- > From: Daniel Fahlgren [mailto:[EMAIL PROTECTED] > Sent: 28 May 2004 12:39 > To: Wez Furlong > Cc: [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] RC3RC1 > >

RE: [PHP-DEV] RC3RC1

2004-05-28 Thread Wez Furlong
Thanks! Can you check if there is a guard for the grantpt function too? --Wez. > -Original Message- > From: Daniel Fahlgren [mailto:[EMAIL PROTECTED] > Sent: 28 May 2004 12:39 > To: Wez Furlong > Cc: [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] RC3RC1 > > On Fr

Re: [PHP-DEV] RC3RC1

2004-05-28 Thread Daniel Fahlgren
On Fri, May 28, 2004 at 11:16:51AM +0100, Wez Furlong wrote: > These are all needed in different combinations on different systems. > Don't you just love standards!? Mmm.. And the standard on Irix is #define _BSD_COMPAT / Daniel Fahlgren -- I live the way I type; fast, with a lot of mistakes D

RE: [PHP-DEV] RC3RC1

2004-05-28 Thread Wez Furlong
ginal Message- > From: Marcus Bointon [mailto:[EMAIL PROTECTED] > Sent: 28 May 2004 01:38 > To: PHP internals > Subject: Re: [PHP-DEV] RC3RC1 > > on 27/5/04 21:11, Curt Zirzow at [EMAIL PROTECTED] wrote: > > > In file included > > from /usr/home/curt/source/php-5.0.0R

RE: [PHP-DEV] RC3RC1

2004-05-28 Thread Wez Furlong
These are all needed in different combinations on different systems. Don't you just love standards!? --Wez. > > #define __EXTENSIONS__ > > #define _ALL_SOURCE > > #include > > > Yep, those defines are there, but If I add > > #define __BSD_VISIBLE 1 > > It works. > > > I tracked it down th

RE: [PHP-DEV] RC3RC1

2004-05-28 Thread Wez Furlong
So a "plain" _XOPEN_SOURCE works on fbsd? --Wez. > -Original Message- > From: Curt Zirzow [mailto:[EMAIL PROTECTED] > Sent: 28 May 2004 05:51 > To: [EMAIL PROTECTED] > Subject: Re: [PHP-DEV] RC3RC1 > > * Thus wrote Curt Zirzow ([EMAIL PROTECTED]): >

Re: [PHP-DEV] RC3RC1

2004-05-27 Thread Curt Zirzow
* Thus wrote Curt Zirzow ([EMAIL PROTECTED]): > I tracked it down that it broke for me at revision 1.21 (the pty > support for proc_open), the macro #define _XOPEN_SOURCE 500 causes > my system to change which POSIX version to compile with. Actually it was revision 1.24 that broke things for me,

Re: [PHP-DEV] RC3RC1

2004-05-27 Thread Curt Zirzow
* Thus wrote Daniel Fahlgren ([EMAIL PROTECTED]): > On Thu, May 27, 2004 at 08:11:17PM +, Curt Zirzow wrote: > > * Thus wrote Andi Gutmans ([EMAIL PROTECTED]): > > > Please test. If there are no critical problems I'll release RC3 tomorrow > > > which I think will be the last RC for 5.0. > > >

Re: [PHP-DEV] RC3RC1

2004-05-27 Thread Curt Zirzow
* Thus wrote Daniel Fahlgren ([EMAIL PROTECTED]): > On Thu, May 27, 2004 at 08:11:17PM +, Curt Zirzow wrote: > > * Thus wrote Andi Gutmans ([EMAIL PROTECTED]): > > > Please test. If there are no critical problems I'll release RC3 tomorrow > > > which I think will be the last RC for 5.0. > > >

Re: [PHP-DEV] RC3RC1

2004-05-27 Thread Marcus Bointon
on 27/5/04 21:11, Curt Zirzow at [EMAIL PROTECTED] wrote: > In file included > from /usr/home/curt/source/php-5.0.0RC3RC1/Zend/zend.h:244, > from /usr/home/curt/source/php-5.0.0RC3RC1/main/php.h:34, > from /usr/home/curt/source/php-5.0.0RC3RC1/ext/standard/proc_open.c:25: > /usr/home/curt/source/p

Re: [PHP-DEV] RC3RC1

2004-05-27 Thread Daniel Fahlgren
On Thu, May 27, 2004 at 08:11:17PM +, Curt Zirzow wrote: > * Thus wrote Andi Gutmans ([EMAIL PROTECTED]): > > Please test. If there are no critical problems I'll release RC3 tomorrow > > which I think will be the last RC for 5.0. > > > > I'm getting an error during compile, > [..] > In file i

Re: [PHP-DEV] RC3RC1

2004-05-27 Thread Curt Zirzow
* Thus wrote Andi Gutmans ([EMAIL PROTECTED]): > Please test. If there are no critical problems I'll release RC3 tomorrow > which I think will be the last RC for 5.0. > I'm getting an error during compile, /bin/sh /usr/home/curt/source/php-5.0.0RC3RC1/libtool --silent --preserve-dup-deps --mode=