Re: [PHP-DEV] Please do not call zval_dtor on recursive array

2012-10-18 Thread Laruence
Hi: it's great, I tested, and committed. :) thanks On Thu, Oct 18, 2012 at 7:19 PM, Dmitry Stogov wrote: > I think, I've found a more simple fix (attached) that don't require > extension patching and even allow to optimize ZE a bit. > > Laruence, can you please verify it. > Sorry, I'm quite bu

Re: [PHP-DEV] Please do not call zval_dtor on recursive array

2012-10-18 Thread Dmitry Stogov
I think, I've found a more simple fix (attached) that don't require extension patching and even allow to optimize ZE a bit. Laruence, can you please verify it. Sorry, I'm quite busy with other tasks. Thanks. Dmitry. On 10/18/2012 02:56 PM, Laruence wrote: On Thu, Oct 18, 2012 at 6:45 PM, Pier

Re: [PHP-DEV] Please do not call zval_dtor on recursive array

2012-10-18 Thread Laruence
On Thu, Oct 18, 2012 at 6:45 PM, Pierre Joye wrote: > hi Dmitry, Laruence! > > On Thu, Oct 18, 2012 at 11:46 AM, Laruence wrote: >> Hey: >> >> recently we found a problem, that is "usage zval_dtor on a recursive >> array while gc enabled" has chance to result a segfault. >> >> a reproduce sc

Re: [PHP-DEV] Please do not call zval_dtor on recursive array

2012-10-18 Thread Pierre Joye
hi Dmitry, Laruence! On Thu, Oct 18, 2012 at 11:46 AM, Laruence wrote: > Hey: > > recently we found a problem, that is "usage zval_dtor on a recursive > array while gc enabled" has chance to result a segfault. > > a reproduce script could be found here: > https://github.com/php/php-src/blob/