Re: [PHP-DEV] Performance improvements

2010-04-13 Thread Sebastian Bergmann
Am 13.04.2010 09:12, schrieb Zeev Suraski: > Dmitry's in the process of separating the different improvements into > separate patches and improving their consistency while at it; We'll > also work on RFC(s). Great to hear! I'll be glad to help with testing the patches once they are available.

Re: [PHP-DEV] Performance improvements

2010-04-13 Thread Zeev Suraski
At 17:32 11/04/2010, Sebastian Bergmann wrote: Am 11.04.2010 16:21, schrieb Lukas Kahwe Smith: > So where do we stand here? I was wondering the same. Dmitry's in the process of separating the different improvements into separate patches and improving their consistency while at it; We'll al

Re: [PHP-DEV] Performance improvements

2010-04-11 Thread Sebastian Bergmann
Am 11.04.2010 16:21, schrieb Lukas Kahwe Smith: > So where do we stand here? I was wondering the same. -- Sebastian BergmannCo-Founder and Principal Consultant http://sebastian-bergmann.de/ http://thePHP.cc/ -- PHP Internals - PHP Runtime Develop

Re: [PHP-DEV] Performance improvements

2010-04-11 Thread Lukas Kahwe Smith
On 25.03.2010, at 18:07, Zeev Suraski wrote: > At 18:51 25/03/2010, Sebastian Bergmann wrote: > >> Zeev Suraski wrote: >> > What does it contain? >> >> It looks to me as if the patch would also reduce the memory footprint: > > That makes perfect sense... Thanks for sharing the results! So w

Re: [PHP-DEV] Performance improvements

2010-03-25 Thread Zeev Suraski
At 18:51 25/03/2010, Sebastian Bergmann wrote: Zeev Suraski wrote: > What does it contain? It looks to me as if the patch would also reduce the memory footprint: That makes perfect sense... Thanks for sharing the results! Zeev -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] Performance improvements

2010-03-25 Thread Sebastian Bergmann
Zeev Suraski wrote: > What does it contain? It looks to me as if the patch would also reduce the memory footprint: s...@thinkpad Framework % time /usr/local/php-5.3.2/bin/php \ ../../../phpunit.php AssertTest PHPUnit @package_version@ by Sebastian Bergmann. .

Re: [PHP-DEV] Performance improvements

2010-03-25 Thread Sebastian Bergmann
Sebastian Bergmann wrote: > Zeev Suraski wrote: >> Patch available at: http://bit.ly/aDPTmv Another note: PHP 5.3.99 + patch only built for me after manually running zend_vm_gen.php to update the generated files. -- Sebastian BergmannCo-Founder and Principal Consultant http

Re: [PHP-DEV] Performance improvements

2010-03-25 Thread Sebastian Bergmann
Zeev Suraski wrote: > Patch available at: http://bit.ly/aDPTmv ext/xsl seems to be broken: /usr/local/src/php/php-performance-patch/ext/xsl/xsltprocessor.c: In function ‘zif_xsl_xsltprocessor_import_stylesheet’: /usr/local/src/php/php-performance-patch/ext/xsl/xsltprocessor.c:430: error: too few

Re: [PHP-DEV] Performance improvements

2010-03-25 Thread Dmitry Stogov
Moriyoshi Koizumi wrote: Hi, On Thu, Mar 25, 2010 at 8:41 AM, Stanislav Malyshev wrote: Hi! Wouldn't it suffice to add a field for the hash value and a flag that indicates its validity to zval instead of appending zend_literal everywhere? Enlarging zval would be costly (the engine uses to

Re: [PHP-DEV] Performance improvements

2010-03-25 Thread Dmitry Stogov
Hi Moriyoshi, Moriyoshi Koizumi wrote: Hi, Wouldn't it suffice to add a field for the hash value and a flag that indicates its validity to zval instead of appending zend_literal everywhere? We used the approach you suggest on the early stages of development, but then realized that passing ze

Re: [PHP-DEV] Performance improvements

2010-03-25 Thread Moriyoshi Koizumi
Hi, On Thu, Mar 25, 2010 at 8:41 AM, Stanislav Malyshev wrote: > Hi! > >> Wouldn't it suffice to add a field for the hash value and a flag that >> indicates its validity to zval instead of appending zend_literal >> everywhere? > > Enlarging zval would be costly (the engine uses tons of zvals) and

Re: [PHP-DEV] Performance improvements

2010-03-24 Thread William A. Rowe Jr.
On 3/24/2010 6:41 PM, Stanislav Malyshev wrote: > Hi! > >> Wouldn't it suffice to add a field for the hash value and a flag that >> indicates its validity to zval instead of appending zend_literal >> everywhere? > > Enlarging zval would be costly (the engine uses tons of zvals) and may > also be

Re: [PHP-DEV] Performance improvements

2010-03-24 Thread Stanislav Malyshev
Hi! Wouldn't it suffice to add a field for the hash value and a flag that indicates its validity to zval instead of appending zend_literal everywhere? Enlarging zval would be costly (the engine uses tons of zvals) and may also be more complicated to track (all zval operations now would also

Re: [PHP-DEV] Performance improvements

2010-03-24 Thread Moriyoshi Koizumi
Hi, Wouldn't it suffice to add a field for the hash value and a flag that indicates its validity to zval instead of appending zend_literal everywhere? Moriyoshi On Wed, Mar 24, 2010 at 11:12 PM, Zeev Suraski wrote: > Hi, > > Over the last few weeks we've been working on several ideas we had for

Re: [PHP-DEV] Performance improvements

2010-03-24 Thread Patrick ALLAERT
Hi, 2010/3/24 Zeev Suraski : > Hi, > > Over the last few weeks we've been working on several ideas we had for > performance enhancements. We've managed to make some good progress.  Our > initial tests show roughly 10% speed improvement on real world apps.  On > pure OO code we're seeing as much as

Re: [PHP-DEV] Performance improvements

2010-03-24 Thread Dmitry Stogov
Hi Rasmus, Rasmus Lerdorf wrote: On 03/24/2010 07:12 AM, Zeev Suraski wrote: Hi, Over the last few weeks we've been working on several ideas we had for performance enhancements. We've managed to make some good progress. Our initial tests show roughly 10% speed improvement on real world apps.

Re: [PHP-DEV] Performance improvements

2010-03-24 Thread Rasmus Lerdorf
On 03/24/2010 07:12 AM, Zeev Suraski wrote: > Hi, > > Over the last few weeks we've been working on several ideas we had for > performance enhancements. We've managed to make some good progress. Our > initial tests show roughly 10% speed improvement on real world apps. On > pure OO code we're se