Re: [PHP-DEV] Patches for a few Date/time related bugs

2010-03-02 Thread Arvind Srinivasan
Hi Derick, When you have some time, please could you review the patches I've added to each of the following date/time-related bugs. If the fix for 49778 is applied, then I'll need to change one of the other test cases (50559) that prints the days value of DateInterval objects. http://bugs.php.ne

Re: [PHP-DEV] Patches for a few Date/time related bugs

2010-01-27 Thread Arvind Srinivasan
Thanks Derick. Please could you point me to info on how the timelib_timezone_db_data (in ext/date/lib/timezonedb.h) is generated. /* This is a generated file, do not modify */ const unsigned char timelib_timezone_db_data_builtin[257664] = { (A couple of the timezone related bugs I looked at used

Re: [PHP-DEV] Patches for a few Date/time related bugs

2010-01-27 Thread Derick Rethans
On Wed, 20 Jan 2010, Arvind Srinivasan wrote: > I've updated each of the following bug reports > > http://bugs.php.net/bug.php?id=50475 - DateTime::setISODate followed > by DateTime::setTime > > http://bugs.php.net/bug.php?id=49059 - DateTime::diff() repeats > previous sub() operation > > http: