Re: [PHP-DEV] PHP socket ethernet support - step 2

2025-03-05 Thread Tim Düsterhus
Hi Am 2025-03-05 13:11, schrieb David CARLIER: And what is the payload object, is that just stdClass? Not really it's supposed to be one of the new classes. Okay, please check if you can find a more appropriate type in the stub then. `?object` is awfully generic (and thus useless to the u

Re: [PHP-DEV] PHP socket ethernet support - step 2

2025-03-05 Thread David CARLIER
On Tue, 4 Mar 2025 at 22:34, Tim Düsterhus wrote: > Hi > > On 3/4/25 23:18, Gina P. Banyard wrote: > > Those two classes predate the Namespaces in bundled PHP extensions [1] > RFC, I do think adding a namespace is better. > > And we could also move the two classes into the new namespace and add >

Re: [PHP-DEV] PHP socket ethernet support - step 2

2025-03-04 Thread Tim Düsterhus
Hi On 3/4/25 23:18, Gina P. Banyard wrote: Those two classes predate the Namespaces in bundled PHP extensions [1] RFC, I do think adding a namespace is better. And we could also move the two classes into the new namespace and add class aliases for the global ones, considering they are quite re

Re: [PHP-DEV] PHP socket ethernet support - step 2

2025-03-04 Thread Gina P. Banyard
On Monday, 3 March 2025 at 21:20, Jakub Zelenka wrote: > Hi, > >> I am working on the second pass of this feature and write here because of >> the legitimate concern regarding new classes to add. >> >> [PR here](https://github.com/php/php-src/pull/17926) > > For those that want to quickly see th

Re: [PHP-DEV] PHP socket ethernet support - step 2

2025-03-04 Thread David CARLIER
On Mon, 3 Mar 2025 at 21:21, Jakub Zelenka wrote: > Hi, > > >> I am working on the second pass of this feature and write here because of >> the legitimate concern regarding new classes to add. >> >> PR here >> > > For those that want to quickly see the

Re: [PHP-DEV] PHP socket ethernet support - step 2

2025-03-03 Thread Jakub Zelenka
Hi, > I am working on the second pass of this feature and write here because of > the legitimate concern regarding new classes to add. > > PR here > For those that want to quickly see the actually classes, here is a stub link: https://github.com/php/ph