Hi Gabriel,
> Let's have this patch merged into PHP 8.0 (`master` branch as of today), I
> have nothing against it.>
> About PHPs 7.3 and 7.4: if the performance improvements are this massive as
> describe in this email, I'm :+1: to have it on those versions as well.
The mileage may very: running
The script I used to pinpoint this problem and test my temporary fix,
and later Matteo's PR is linked in the bug report I oppened. Should be
simple to run if anyone is interested in trying. I found this on
pdo_pgsql, but looking at the code it looks like the problem should
happen on other pdo_*
On Fri, 28 Aug 2020 at 09:19, Matteo Beccati wrote:
> Hi George,
>
> /cc release managers - pls don't hate me ;-)
>
> On 27/08/2020 10:23, Matteo Beccati wrote:
> >
> > On 26/08/2020 19:28, G. P. B. wrote:
> >> This can still target PHP 8.0 as this seems to be akin to a bug this
> >> might even b
Hi George,
/cc release managers - pls don't hate me ;-)
On 27/08/2020 10:23, Matteo Beccati wrote:
>
> On 26/08/2020 19:28, G. P. B. wrote:
>> This can still target PHP 8.0 as this seems to be akin to a bug this
>> might even be applicable to PHP 7.3/7.4. Anyways, good catch.
>
> You could be rig
Hi George,
On 26/08/2020 19:28, G. P. B. wrote:
> Just that you are aware the emails from both of you went to my spam folder.
Thanks. Alas, big G doesn't like the fact I'm using my own email server,
despite all DKIM/SPF/whatnot being properly configured, according to them.
> Back to the matter,
Just that you are aware the emails from both of you went to my spam folder.
Thanks for the info. If anyone has any idea why we went to spam, please
let us know.
The reason I didn't create a pull request immediately is that I don't
have a concrete fix. The diff that I sent just shows where I c
Hi Dino,
On 26/08/2020 15:02, Dino Pejaković wrote:
> [snip]
> ||+ // if (!dispatch_param_event(stmt, PDO_PARAM_EVT_FETCH_POST)) {||
> ||+ // return 0;||
> ||+ // }||
> || ||
> || if (do_bind && stmt->bound_columns) {||
> || /* update those bound column
Just that you are aware the emails from both of you went to my spam folder.
Back to the matter, this is the correct list to email Dino, however could
you
open a pull request on GitHub for this change so that more eyes (and
especially eyes from people which know PDO) can have a look?
Please provid
