> Greetings Alexey,
>
> I'm unable to provide useful comments for this patch, but am CCing the
> official ext/curl maintainer (Ilia) and you now have karma for committing
> tests.
>
Thank you, Philip, for karma and for pushing that forward, I really
appreciate that.
--
Regards,
Shein Alexey
-
On May 27, 2011, at 3:40 AM, Alexey Shein wrote:
> It seems my last letter didn't came to the list, resending it.
>
> So this is new version of this patch - with curl_multi_exec involved
> and accordingly changed tests. Let me know what you think about it.
>
> Additionally, I found another test
So what do you think should be done here? Check closed streams and
reset them to default as in my first try?
--
Regards,
Shein Alexey
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Em Fri, 20 May 2011 12:14:07 +0100, Pierre Joye
escreveu:
On Fri, May 20, 2011 at 1:12 PM, Gustavo Lopes
wrote:
Now, I'm starting to think something in the line of your original patch
is better. Of course, curl_multi_exec and the other options would have
to be considered too.
Yes, t
On Fri, May 20, 2011 at 1:12 PM, Gustavo Lopes wrote:
> Now, I'm starting to think something in the line of your original patch is
> better. Of course, curl_multi_exec and the other options would have to be
> considered too.
Yes, that's what I told Alexy on IRC as well. Especially as I don't
see
Em Fri, 20 May 2011 07:59:51 +0100, Alexey Shein
escreveu:
* I think a better strategy would be to just dup the file descriptor
gotten after the cast in curl_setopt, store it (instead of storing the
zval) and close it on curl handle destruction. This way we wouldn't
have to worry
about z
>> * I think a better strategy would be to just dup the file descriptor gotten
>> after the cast in curl_setopt, store it (instead of storing the zval) and
>> close it on curl handle destruction. This way we wouldn't have to worry
>> about zval refcounts or whether the file descriptor obtained is s
> A few remarks:
>
> * Isn't this supposed to be fixed? Was there something that triggered a
> regression?
As far as I can see Jani checked only case when already closed file
descriptor was passed to curl_setopt. Here's the check is performed in
curl_exec, i.e. in curl_setopt file descriptor was v
On Tue, May 17, 2011 at 3:54 PM, Pierre Joye wrote:
> hi,
>
> On Tue, May 17, 2011 at 3:40 PM, Alexey Shein wrote:
> > I need karma to commit test fixes:
> > 1) session_encode_basic - added serialize_precision=100 ini setting
>
> Is it not fixed already?
>
>
there were other tests with missing s
Em Tue, 17 May 2011 14:40:53 +0100, Alexey Shein
escreveu:
2) fix for http://bugs.php.net/48203: there's a segfault when
CURLOPT_STDERR file pointer is closed before calling curl_exec, i.e.
like this:
$fp = fopen(dirname(__FILE__) . '/bug48203.tmp', 'w');
$ch = curl_init();
curl_setopt($ch
Created http://bugs.php.net/bug.php?id=54798.
--
Regards,
Shein Alexey
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
2011/5/17 Pierre Joye :
> hi,
>
> On Tue, May 17, 2011 at 3:40 PM, Alexey Shein wrote:
>> I need karma to commit test fixes:
>> 1) session_encode_basic - added serialize_precision=100 ini setting
>
> Is it not fixed already?
>
As Tyrael already said this one was missed.
>> 2) fix for http://bugs
hi,
On Tue, May 17, 2011 at 3:40 PM, Alexey Shein wrote:
> I need karma to commit test fixes:
> 1) session_encode_basic - added serialize_precision=100 ini setting
Is it not fixed already?
> 2) fix for http://bugs.php.net/48203: there's a segfault when
Pls open a bug report and attach the patc
13 matches
Mail list logo
