On Thu, 24 Aug 2017 11:55:10 +0200 / "Christoph M. Becker"
said :
> It seems to me this is rather simple: if a feature is uncontroversial,
> it doesn't need an RFC. Since nobody objected against PR #2528, it
> was merged (after some weeks). However, there have been objections
> against PR #2698
On 24.08.2017 at 00:06, Adam Baratz wrote:
>> That change was implemented in the SQLite3 extension without a RFC, so I'm
>> quite confused here.
>
> My literal reading of the contribution guide[1] is that new features should
> be preceded by an RFC, though there are certainly cases where this doe
>
> That change was implemented in the SQLite3 extension without a RFC, so I'm
> quite confused here.
>
My literal reading of the contribution guide[1] is that new features should
be preceded by an RFC, though there are certainly cases where this doesn't
happen. I don't have a clear enough underst
On 23/08/17 06:15, BohwaZ/PHP wrote:
> I'm not gonna create another way of having driver-specific features that
> wouldn't make sense in relation to existing methods, and I don't have
> time to rewrite a significant part of PDO that would cause a major
> BC-break.
The original intention of PDO was
PDO\sqlite_open_blob($pdo, ...).
And no, just because a lot of folks jumped from the bridge doesn't make
jumping from the bridge acceptable. You can pursue the approach, but you
will get a negative vote from over here: that's also where my influence
stops though.
On 23 Aug 2017 7:15 AM, "BohwaZ/P
Le 23/08/2017 16:57, Marco Pivetta a écrit :
I suggest adding dedicated functions that given a PDO instance and the
parameters you needed do what you want to do.
So if I understand correctly:
$pdo = new PDO('sqlite::memory:');
$extended = new PDO_Extended_SQLite($pdo);
$blob = $extended->openB
I suggest adding dedicated functions that given a PDO instance and the
parameters you needed do what you want to do.
And yes, you are adding new stuff: php-src has this widespread
misunderstanding that "reproducing new lower layer behaviour in upper
layers" should happen no matter what.
On 23 Au
PDO is already a mess, and adding method that appear/disappear
dynamically
whether you enable an extension or not... is a horror show.
From my PoV, since we (doctrine) have to abstract away from it all the
time, we'd rather have it as tidy and well-thought-out as possible,
especially since there
PDO is already a mess, and adding method that appear/disappear dynamically
whether you enable an extension or not... is a horror show.
>From my PoV, since we (doctrine) have to abstract away from it all the
time, we'd rather have it as tidy and well-thought-out as possible,
especially since there
Yes, because once it lands in core, it sticks around for almost
eternity.
Yeah but is it necessary for something that is just missing, because the
pdo_sqlite implementation is incomplete, and is basically following what
already exists, without changing anything?
That change was implemented i
Yes, because once it lands in core, it sticks around for almost eternity.
On 21 Aug 2017 23:54, "BohwaZ/PHP" wrote:
> Le 22/08/2017 07:55, Adam Baratz a écrit :
>
>> A new method is an API change to me, so an RFC would be warranted. I'm
>> reluctant to add driver-specific methods, since that se
On Mon, Aug 21, 2017 at 5:54 PM, BohwaZ/PHP wrote:
> Le 22/08/2017 07:55, Adam Baratz a écrit :
>
>> A new method is an API change to me, so an RFC would be warranted. I'm
>> reluctant to add driver-specific methods, since that seems opposed to
>> PDO's
>> driver-agnostic API, but that's not to s
Le 22/08/2017 07:55, Adam Baratz a écrit :
A new method is an API change to me, so an RFC would be warranted. I'm
reluctant to add driver-specific methods, since that seems opposed to
PDO's
driver-agnostic API, but that's not to say we couldn't hash something
out.
Do we need a RFC every time
>
> I just have proposed a patch to have SQLite3 open_blob feature implemented
> in PDO_SQLite: https://github.com/php/php-src/pull/2698
[cross-posted from GitHub]
A new method is an API change to me, so an RFC would be warranted. I'm
reluctant to add driver-specific methods, since that seems op
14 matches
Mail list logo
