Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-12 Thread Pierre Joye
On Sat, Nov 12, 2011 at 7:54 PM, Edward Z. Yang wrote: > Excerpts from Hannes Magnusson's message of Fri Nov 11 18:54:27 -0500 2011: >> Hmh. >> Whats the difference between .user.ini and -dextension=? >> I hate it when bucketloads of .ini files are picked up when I run PHP via cli > > The idea wou

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-12 Thread Edward Z. Yang
Excerpts from Hannes Magnusson's message of Fri Nov 11 18:54:27 -0500 2011: > Hmh. > Whats the difference between .user.ini and -dextension=? > I hate it when bucketloads of .ini files are picked up when I run PHP via cli The idea would be to make it easy to simulate the same configuration as when

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Hannes Magnusson
On Fri, Nov 11, 2011 at 22:43, Edward Z. Yang wrote: > Excerpts from Rasmus Lerdorf's message of Fri Nov 11 15:45:27 -0500 2011: >> Well, it is simple enough that we don't really need a patch. However, >> generally if you want to submit a patch it needs to be against a current >> svn branch and no

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Pierre Joye
On Fri, Nov 11, 2011 at 10:43 PM, Edward Z. Yang wrote: >> The other issue with your patch is that you are enabling this for the >> fpm sapi. I thought we agreed that this should only be in the sapis that >> supported dl() and those are cgi, cli and embed. And .user.ini doesn't >> apply to embed,

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Edward Z. Yang
Excerpts from Rasmus Lerdorf's message of Fri Nov 11 15:45:27 -0500 2011: > Well, it is simple enough that we don't really need a patch. However, > generally if you want to submit a patch it needs to be against a current > svn branch and not an old release. You want to minimize the work people > wi

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Pierre Joye
hi, On Fri, Nov 11, 2011 at 9:45 PM, Rasmus Lerdorf wrote: > The other issue with your patch is that you are enabling this for the > fpm sapi. I thought we agreed that this should only be in the sapis that > supported dl() and those are cgi, cli and embed. And .user.ini doesn't > apply to embed,

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Rasmus Lerdorf
Well, it is simple enough that we don't really need a patch. However, generally if you want to submit a patch it needs to be against a current svn branch and not an old release. You want to minimize the work people will need to do to look at your suggested change. The other issue with your patch i

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Edward Z. Yang
http://svn.php.net/repository/php/php-src/branches/PHP_5_3 r318957 We also applied it to 5.3.8 release, although we had to fix up the patch for that. I can port it to 5.4. Edward Excerpts from Rasmus Lerdorf's message of Fri Nov 11 14:38:13 -0500 2011: > Which branch in this patch against? It d

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Rasmus Lerdorf
Which branch in this patch against? It doesn't apply to 5_3/5_4/trunk It is short and simple so I could do it manually, of course, but I'd like to know what you have been testing it against. On 11/10/2011 07:14 PM, Edward Z. Yang wrote: > Here is the proposed patch (sans tests; we did our own man

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Will Fitch
You should always tie a patch to a bug/feature request. Need to know/remember why the patch was applied in the first place. On Nov 11, 2011, at 2:32 PM, Edward Z. Yang wrote: > Well, I'm kind of hoping this patch will go in, so we don't have to bother > with a bug. I can if you really want me to

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Edward Z. Yang
Well, I'm kind of hoping this patch will go in, so we don't have to bother with a bug. I can if you really want me to. Cheers, Edward Excerpts from Christopher Jones's message of Fri Nov 11 14:28:30 -0500 2011: > > On 11/10/2011 07:14 PM, Edward Z. Yang wrote: > > > The change to zlist_clean is

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-11 Thread Christopher Jones
On 11/10/2011 07:14 PM, Edward Z. Yang wrote: The change to zlist_clean is necessary because otherwise extension_lists can't be reused for the second round of extension appliations (since the head and tail pointers have garbage in them). You should probably take that fix regardless of what y

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-10 Thread Edward Z. Yang
Here is the proposed patch (sans tests; we did our own manual testing on 32-bit and 64-bit, and had to fix an unrelated bug; will provide tests when you say so): http://web.mit.edu/~ezyang/Public/php-user-ini-extension.patch The change to zlist_clean is necessary because otherwise extension_l

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-08 Thread Yasuo Ohgaki
It seems working on my MacBook. I just tried php-src-5.4 with $ uname -a Darwin esi-yasmc1.esi.local 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun 7 16:33:36 PDT 2011; root:xnu-1504.15.3~1/RELEASE_I386 i386 $./configure && make and got following result. $ USE_ZEND_ALLOC=0 valgrind ./sapi/cli/ph

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-08 Thread Edward Z. Yang
Excerpts from Rasmus Lerdorf's message of Tue Nov 08 03:54:56 -0500 2011: > It should match the dl() SAPI availability. OK, can do! Cheers, Edward -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-08 Thread Rasmus Lerdorf
On 11/08/2011 12:46 AM, Edward Z. Yang wrote: > Excerpts from Rasmus Lerdorf's message of Tue Nov 08 03:40:17 -0500 2011: >> You are aware that these extensions can't be unloaded, right? So one >> user loading an extension will potentially be stepping on another user >> and breaking their code. >

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-08 Thread Edward Z. Yang
Excerpts from Rasmus Lerdorf's message of Tue Nov 08 03:40:17 -0500 2011: > You are aware that these extensions can't be unloaded, right? So one > user loading an extension will potentially be stepping on another user > and breaking their code. Yep. If you like, I can make it so that it only appli

Re: [PHP-DEV] Load extensions for .user.ini files

2011-11-08 Thread Rasmus Lerdorf
On 11/08/2011 12:23 AM, Edward Z. Yang wrote: > Hello all, > > My team is interested in permitting .user.ini files to load > extensions. We believe this to be a simple fix: add > an invocation of php_ini_register_extensions to the end > of sapi/cgi/cgi-main.c. > > I don't believe this steps on a