Re: [PHP-DEV] Interbase bugfixes

2007-10-24 Thread Lester Caine
Lars Westermann wrote: I can't find any changed files en ext/interbase on the PHP_5_2 branch ... Which file contains the fix? I can even tell you which lines were changed since 5_1: http://cvs.php.net/viewvc.cgi/php-src/ext/interbase/ibase_blobs.c?r1=1.13&r2=1.9.2.2 Highlighted the problem

Re: [PHP-DEV] Interbase bugfixes

2007-10-24 Thread Lester Caine
Lars Westermann wrote: I've had a long mail-dialogue with Wez regarding bugfixes for the Interbase modules (the old interbase and the new PDO version). In the PHP_5_3 branch I have worked on the files mentioned below. As these files aren't changed from the PHP_5_2 branch, the bugfixes will easil

Re: [PHP-DEV] Interbase bugfixes

2007-10-23 Thread Antony Dovgal
On 24.10.2007 02:30, Lars Westermann wrote: > Hi > > For ibase_query.c the unified diff is: Please don't include diffs into the message body (you can try applying it now yourself to see why). It's also become completely unreadable, especially the first part of it. And some comments on WHY the di

Re: [PHP-DEV] Interbase bugfixes

2007-10-23 Thread Lars Westermann
Hi For ibase_query.c the unified diff is: diff -u -r1.23.2.1.2.10 ibase_query.c --- ibase_query.c 7 Jun 2007 08:59:00 - 1.23.2.1.2.10 +++ ibase_query.c 23 Oct 2007 18:18:28 - @@ -144,8 +144,13 @@ } if (ib_query->stmt) { IBDEBUG("Dropping statement handle (free_query)..."); - if (isc_dsql_

Re: [PHP-DEV] Interbase bugfixes

2007-10-23 Thread Antony Dovgal
On 24.10.2007 02:11, Lars Westermann wrote: > Hi! > > I've had a long mail-dialogue with Wez regarding bugfixes for the Interbase > modules (the old interbase and the new PDO version). In the PHP_5_3 branch I > have worked on the files mentioned below. As these files aren't changed from > the PHP_