Re: [PHP-DEV] Implode() FR and Patch

2008-12-08 Thread Christian Schneider
Igor Feghali wrote: > // NOTE: leaving the callback function empty is not desired. 0 and 0.0 > should not be skipped in the implode array ! > array_filter($arr, 'myfunc'); > implode('foo', $arr); > > against: > > implode('foo', $arr, true); implode('foo', array_filter($arr, 'myfunc')); Simple e

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Igor Feghali
On Sat, Dec 6, 2008 at 22:52, Lars Strojny <[EMAIL PROTECTED]> wrote: > Alright, than I would appreciate a few real world use cases. Ok one immediate use case I can think of: http://pear.php.net/package/Numbers_Words In brazilian portuguese we write numbers like that: 1023 => mil e vinte e tres

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Lars Strojny
Hi Igor, Am Samstag, den 06.12.2008, 22:38 -0200 schrieb Igor Feghali: > On Sat, Dec 6, 2008 at 21:07, Lars Strojny <[EMAIL PROTECTED]> wrote: [...] > nope. I just think its something too "simple", too "obvious" and too > "frequent" so it deserves the love of php internals. Having to call > array_

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Igor Feghali
On Sat, Dec 6, 2008 at 21:07, Lars Strojny <[EMAIL PROTECTED]> wrote: > enough. You ran into a situation where this became a bottleneck in your > code? nope. I just think its something too "simple", too "obvious" and too "frequent" so it deserves the love of php internals. Having to call array_fil

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Lars Strojny
Hi Igor, thanks for the patch, I think it is an idea worth considering. Except that the proposed solution with executing array_filter() might be enough. You ran into a situation where this became a bottleneck in your code? Am Samstag, den 06.12.2008, 00:21 -0200 schrieb Igor Feghali: > Hello Ther

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Kenan R Sulayman
I'd appreciate it*

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Kenan R Sulayman
Dear Igor, in local tests, here on my server, the performance was, every time I did it, at least 0.02 Second up to 0.1 Second faster than the origin. I'd appreciate, if this feature got included into the next build. Thanks, -- (c) Kenan Sulayman Freelance Designer and Programmer Life's Live Poet

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Igor Feghali
Hello Kenan, Thank you for your feedback. On Sat, Dec 6, 2008 at 07:41, Kenan R Sulayman <[EMAIL PROTECTED]> wrote: > A question: hasn't the new one got a better performance ? According to my tests I would say they perform are equal. Please let me know if you did any deeper tests. PS: on string

Re: [PHP-DEV] Implode() FR and Patch

2008-12-06 Thread Kenan R Sulayman
Dear Igor, that's a really great feature! A question: hasn't the new one got a better performance ? Thanks, -- (c) Kenan Sulayman Freelance Designer and Programmer Life's Live Poetry http://MyJurnal.tk/