Re: [PHP-DEV] Fwd: [PATCH] added: openssl_csr_subject()

2004-10-12 Thread Greg MacLellan
Wez Furlong wrote: If you can make that change and then either put the diff online, or as a regular MIME plain text attachment and not inlined, so that it is easy to get at without it being mangled in the email, I will apply it to CVS. Done. It actually didn't come out mangled for me at all (mo

Re: [PHP-DEV] Fwd: [PATCH] added: openssl_csr_subject()

2004-10-12 Thread Wez Furlong
On Tue, 12 Oct 2004 14:47:05 -0400, Greg MacLellan <[EMAIL PROTECTED]> wrote: > Now uses X509_NAME_print_ex(), using the XN_FLAGS_RFC2253 option. Looks much better now > bool openssl_csr_subject(mixed csr, string &out) > > Now, I don't do very much C coding, and I'm pretty new to the zend API..

Re: [PHP-DEV] Fwd: [PATCH] added: openssl_csr_subject()

2004-10-12 Thread Greg MacLellan
Wez Furlong wrote: Two or three comments: - You leak the dynamically allocated buffer returned by X509_NAME_oneline() - X509_NAME_oneline() man page says that its use is discouraged in favour of smarter functions. Is there a possibility that someone will need that functionality? - if you can solve

Re: [PHP-DEV] Fwd: [PATCH] added: openssl_csr_subject()

2004-10-08 Thread Wez Furlong
Two or three comments: - You leak the dynamically allocated buffer returned by X509_NAME_oneline() - X509_NAME_oneline() man page says that its use is discouraged in favour of smarter functions. Is there a possibility that someone will need that functionality? - if you can solve/answer both of th