Re: [PHP-DEV] Fw: unpack()

2016-12-19 Thread Dmitry Stogov
Fixed. Thanks for catching and sorry for delay. Dmitry. From: Leigh Sent: Tuesday, December 13, 2016 6:36:00 PM To: Dmitry Stogov Cc: Nikita Popov; internals@lists.php.net; Hynek Bartoš Subject: Re: [PHP-DEV] Fw: unpack() On 29 February 2016 at 07:43, Dmitry

Re: [PHP-DEV] Fw: unpack()

2016-12-13 Thread Leigh
way how the proposed patch works. > > Thanks. Dmitry. > > > > From: Leigh > Sent: Thursday, February 25, 2016 18:20 > To: Dmitry Stogov > Cc: Nikita Popov; internals@lists.php.net; Hynek Bartoš > Subject: Re: [PHP-DEV] Fw: unpa

Re: [PHP-DEV] Fw: unpack()

2016-03-02 Thread Dmitry Stogov
ogov Cc: Nikita Popov; internals@lists.php.net; Hynek Bartoš Subject: Re: [PHP-DEV] Fw: unpack() On 25 February 2016 at 13:02, Dmitry Stogov wrote: > > I've just got to know about possible usage of "@" in unpack(), but it seems > doesn't work at all > > $ sapi/cl

Re: [PHP-DEV] Fw: unpack()

2016-02-28 Thread Dmitry Stogov
ks. Dmitry. From: Leigh Sent: Thursday, February 25, 2016 18:20 To: Dmitry Stogov Cc: Nikita Popov; internals@lists.php.net; Hynek Bartoš Subject: Re: [PHP-DEV] Fw: unpack() On 25 February 2016 at 13:02, Dmitry Stogov wrote: > > I've just got to know about possible usage of &q

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Leigh
On 25 February 2016 at 13:02, Dmitry Stogov wrote: > > I've just got to know about possible usage of "@" in unpack(), but it seems > doesn't work at all > > $ sapi/cli/php -r 'var_dump(unpack("@0l", "\x01\x00\x00\x00")); ' > array(0) { > } > > Do I use it properly? > > Thanks. Dmitry. > As Nikita

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Hynek Bartoš
This is a good point, so I checked my old source codes and I found a note in one of them, that: unpack('@200/'. 'aA', str_repeat(' ', 200). 'ABC') was returning 'B' instead of 'A'. It is some issue which probably was repaired years ago (because it works correctly now), but it allowed me t

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Hynek Bartoš
Hello all! It all depends on usage of this function. My suggestion pointed to the situation when you have some structures inside binary stream (similar to C struct), so you have constant $format argument. The usage of '@' should be relative to the start of the parsing so it should start at the offs

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Nikita Popov
On Thu, Feb 25, 2016 at 2:02 PM, Dmitry Stogov wrote: > > > On 02/25/2016 03:05 PM, Nikita Popov wrote: > > On Thu, Feb 25, 2016 at 8:08 AM, Dmitry Stogov wrote: > >> >> >> >> >> From: Dmitry Stogov >> Sent: Wednesday, February 24, 2016 13:35 >> To: Hynek Bartoš;

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Dmitry Stogov
On 02/25/2016 03:05 PM, Nikita Popov wrote: On Thu, Feb 25, 2016 at 8:08 AM, Dmitry Stogov > wrote: From: Dmitry Stogov Sent: Wednesday, February 24, 2016 13:35 To: Hynek Bartoš; php-...@lists.php.net

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Nikita Popov
On Thu, Feb 25, 2016 at 8:08 AM, Dmitry Stogov wrote: > > > > > From: Dmitry Stogov > Sent: Wednesday, February 24, 2016 13:35 > To: Hynek Bartoš; php-...@lists.php.net; php-general-h...@lists.php.net > Subject: Re: unpack() > > > Hi, > > > I think the requested f

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Dmitry Stogov
If RFC is required, could some volunteer take care about it. Thanks. Dmitry. From: Marco Pivetta Sent: Thursday, February 25, 2016 12:01 To: Dmitry Stogov Cc: PHP Internals List; Hynek Bartoš Subject: Re: [PHP-DEV] Fw: unpack() Hi Dmitry, Yes, this is an

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Yasuo Ohgaki
Hi all, On Thu, Feb 25, 2016 at 5:12 PM, Pierre Joye wrote: > On Feb 25, 2016 2:08 PM, "Dmitry Stogov" wrote: >> >> >> >> >> >> From: Dmitry Stogov >> Sent: Wednesday, February 24, 2016 13:35 >> To: Hynek Bartoš; php-...@lists.php.net; php-general-h...@lists.php.

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Marco Pivetta
Hi Dmitry, Yes, this is an API change, and therefore needs an RFC, even if it may look like an obvious/simple change. Functional tests for the new parameter are also needed. Cheers, Marco On Feb 25, 2016 02:08, "Dmitry Stogov" wrote: > > > > > From: Dmitry Sto

Re: [PHP-DEV] Fw: unpack()

2016-02-25 Thread Pierre Joye
On Feb 25, 2016 2:08 PM, "Dmitry Stogov" wrote: > > > > > > From: Dmitry Stogov > Sent: Wednesday, February 24, 2016 13:35 > To: Hynek Bartoš; php-...@lists.php.net; php-general-h...@lists.php.net > Subject: Re: unpack() > > > Hi, > > > I think the requested featur