Re: [PHP-DEV] Fix for bug #25543

2003-10-05 Thread Zeev Suraski
At 15:16 05/10/2003, Thies C. Arntzen wrote:on a sidenote - i once played around by just adding this garbage to a linked list and only reclaim it inside emalloc. that way we don't need to clean it after every op. We plan to completely remove the garbage mechanism after beta 2. Zeev -

Re: [PHP-DEV] Fix for bug #25543

2003-10-05 Thread Moriyoshi Koizumi
"Thies C. Arntzen" <[EMAIL PROTECTED]> wrote: > > on a sidenote - i once played around by just adding this > garbage to a linked list and only reclaim it inside emalloc. > that way we don't need to clean it after every op. > > this won't fix the 25547 but it would make fixing it

Re: [PHP-DEV] Fix for bug #25543

2003-10-05 Thread Thies C. Arntzen
On Sat, Oct 04, 2003 at 12:13:12PM +0200, Andi Gutmans wrote: > At 08:16 AM 10/4/2003 +0900, Moriyoshi Koizumi wrote: > >Andi Gutmans <[EMAIL PROTECTED]> wrote: > > > >> Hi, > >> > >> I don't like this patch because already the gc is a very sensitive > >> mechanism and we're not allowed to collect

Re: [PHP-DEV] Fix for bug #25543

2003-10-04 Thread Andi Gutmans
At 08:16 AM 10/4/2003 +0900, Moriyoshi Koizumi wrote: Andi Gutmans <[EMAIL PROTECTED]> wrote: > Hi, > > I don't like this patch because already the gc is a very sensitive > mechanism and we're not allowed to collect too much or too little at any > given time. Your patch can easily lead to too much

Re: [PHP-DEV] Fix for bug #25543

2003-10-03 Thread Moriyoshi Koizumi
Andi Gutmans <[EMAIL PROTECTED]> wrote: > Hi, > > I don't like this patch because already the gc is a very sensitive > mechanism and we're not allowed to collect too much or too little at any > given time. Your patch can easily lead to too much being collected before > previous zval's are free

Re: [PHP-DEV] Fix for bug #25543

2003-10-03 Thread Andi Gutmans
Hi, I don't like this patch because already the gc is a very sensitive mechanism and we're not allowed to collect too much or too little at any given time. Your patch can easily lead to too much being collected before previous zval's are freed which can lead to problems (this mechanism was ref

Re: [PHP-DEV] Fix for bug #25543

2003-10-03 Thread Moriyoshi Koizumi
Jani Taskinen <[EMAIL PROTECTED]> wrote: > > #25543 is documentation 'bug', what exactly does your > patch fix? I don't see anything wrong with set_error_handler().. > Oops, #25547 is the right number. Moriyoshi -- PHP Internals - PHP Runtime Development Mailing List To unsubscri

Re: [PHP-DEV] Fix for bug #25543

2003-10-03 Thread r.willenbacher
On October 3, 2003 05:43 am, Jani Taskinen wrote: > #25543 is documentation 'bug', what exactly does your > patch fix? I don't see anything wrong with set_error_handler().. > > --Jani > > On Fri, 3 Oct 2003, Moriyoshi Koizumi wrote: > >Attached is a fix for bug #25543 (Error in set_erro

Re: [PHP-DEV] Fix for bug #25543

2003-10-02 Thread Jani Taskinen
#25543 is documentation 'bug', what exactly does your patch fix? I don't see anything wrong with set_error_handler().. --Jani On Fri, 3 Oct 2003, Moriyoshi Koizumi wrote: >Hi, > >Attached is a fix for bug #25543 (Error in set_error_handler() definition), >which is caused b