I'll take care of changing everything to E_WARNING tomorrow.
John
On Fri, 2004-04-16 at 18:27, Andi Gutmans wrote:
> John,
>
> I agree that currently it's better to change these back to real E_WARNINGS.
> I agree that exceptions should be thrown for things which we'd usually make
> E_ERRORs (i
John,
I agree that currently it's better to change these back to real E_WARNINGS.
I agree that exceptions should be thrown for things which we'd usually make
E_ERRORs (if recoverable).
As most people here prefer not to go the route of exceptions, and I think
many (not all) of their reasoning ma
On Fri, 16 Apr 2004, Sterling Hughes wrote:
> Tidy's current error handling scheme is totally messed up - every
> single thing in the extension should be an E_WARNING by PHP standards.
> Its RC2, and this stuff has worked for a long time, breaking it now is
> counterproductive and annoying.
>
> Jo
Tidy's current error handling scheme is totally messed up - every
single thing in the extension should be an E_WARNING by PHP standards.
Its RC2, and this stuff has worked for a long time, breaking it now is
counterproductive and annoying.
John, if you insist on messing up the error handling i
John Coggeshall wrote:
Exceptions from use. I'm not prepared to do that, a failure to open a
file is an exception in OO-world and that's what should be there.
No! OO and exceptions are two completely different things. One is about
data encapsulation and one is about error handling. OO can happily
On Fri, 2004-04-16 at 12:44, Derick Rethans wrote:
> I disgree with this behavior too. E_WARNINGs were never supposed to
> abort a script, that's what we have E_ERRORs for. (Making E_ERROR an
> exception in an OO context is fine, as when it's unhandled it should
> abort the script, just like in PHP
On Fri, 16 Apr 2004, Christian Schneider wrote:
> John Coggeshall wrote:
> > the best compromise I can reach without discarding exceptions entirely,
> > which I believe is even more wrong for OO code.
>
> I disagree. I lost track over the last couple of days, what is everyone
> else's view on this
John Coggeshall wrote:
the best compromise I can reach without discarding exceptions entirely,
which I believe is even more wrong for OO code.
I disagree. I lost track over the last couple of days, what is everyone
else's view on this?
- Chris
--
PHP Internals - PHP Runtime Development Mailing
On Fri, 2004-04-16 at 12:01, Christian Schneider wrote:
> I think this is wrong.
> For E_WARNING the program flow continues unchanged whether you handle
> the return value of e.g. fopen or not.
> For exceptions you _have_ to handle it, otherwise your program aborts.
> Two different things.
I agre
John Coggeshall wrote:
E_WARNINGs are exceptions.
I think this is wrong.
For E_WARNING the program flow continues unchanged whether you handle
the return value of e.g. fopen or not.
For exceptions you _have_ to handle it, otherwise your program aborts.
Two different things.
- Chris
--
PHP Intern
On Fri, 2004-04-16 at 03:32, Derick Rethans wrote:
> Do you mean E_ERRORS become exceptions or also E_WARNINGS? E_WARNINGS
> should never become exceptions as it's a non-fatal error.
E_WARNINGs are exceptions. If you look at the code with the patch
applied, I've downgraded all truly minor error co
On Thu, 15 Apr 2004, John Coggeshall wrote:
> - All errors were re-evaluated, and those (such as a bogus config
> option) were demoted to E_NOTICE or promoted to E_ERROR as
> necessary
> - Those errors which are truly E_WARNING will behave as such when
> called from a procedural co
On Thu, 2004-04-15 at 20:07, Sterling Hughes wrote:
> Also wrong. You never through an E_ERROR for this sort of thing.
Ilia pointed that out, its been corrected -- all zend_error() references
were also changed to php_error_docref() (except in RINIT)
John
--
-=~=--=~=--=~=--=~=--=~=--=~=--=~=-
On Apr 15, 2004, at 4:12 PM, John Coggeshall wrote:
Attached is a patch which I hope will keep people happy when it comes
to
specifically the Tidy extension. I'd like some feedback on this before
I
commit it / throw it away:
Changes:
- All errors were re-evaluated, and those (such as a bogus
Attached is a patch which I hope will keep people happy when it comes to
specifically the Tidy extension. I'd like some feedback on this before I
commit it / throw it away:
Changes:
- All errors were re-evaluated, and those (such as a bogus config
option) were demoted to E_NOTICE or promote
15 matches
Mail list logo
