Re: [PHP-DEV] Deprecation of functions

2006-02-20 Thread Andi Gutmans
You clearly didn't understand what I was trying to say... At 01:18 PM 2/20/2006, Marcus Boerger wrote: Hello Andi, sorry i fixed your issues, discussed with some ppl online and you were clearly working on php at the same time. Further more i am the only one here regularly showing patches bef

Re: [PHP-DEV] Deprecation of functions

2006-02-20 Thread Marcus Boerger
Hello Andi, sorry i fixed your issues, discussed with some ppl online and you were clearly working on php at the same time. Further more i am the only one here regularly showing patches before committing. I guess i should just change to commit without taking anymore care. And yes i did it on pu

Re: [PHP-DEV] Deprecation of functions

2006-02-20 Thread Andi Gutmans
Just for the record I've been spending quite a bit of time, trying to see how we can lower the amount of branches within our opcodes. Although one if() doesn't make a big difference on its own, the large number of branches we have do make a difference. So before you say it's just an integer com

Re: [PHP-DEV] Deprecation of functions

2006-02-19 Thread Marcus Boerger
Hello internals, i digged a bit deeper regarding the assumption that zend_call_function() is missing the abstract check and it shows that right now we delay error generation. The following back trace shows that actually we have a special opcode that is necessary to do so: #0 zend_error (type=1

Re: [PHP-DEV] Deprecation of functions

2006-02-19 Thread Sebastian Bergmann
Marcus Boerger schrieb: > Anyone against? No, I am +1 for a sane way to mark functions/methods as deprectated. -- Sebastian Bergmann http://www.sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69 -- PHP Internals - PHP Runtime