Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD

2008-03-06 Thread Derick Rethans
On Wed, 5 Mar 2008, David Coallier wrote: > > > > I'm talking about extension developers. We will all have to add yet > > > > another #ifdef for this function, in the implementation or to define > > > > php_dirname to keep the implementation clean(er). As it is good to > > > > clean up code

Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD

2008-03-05 Thread Gwynne Raskind
On Mar 5, 2008, at 9:52 PM, David Coallier wrote: I'm talking about extension developers. We will all have to add yet another #ifdef for this function, in the implementation or to define php_dirname to keep the implementation clean(er). As it is good to clean up codes, I'm not sure to remove t

Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD

2008-03-05 Thread David Coallier
> > > I'm talking about extension developers. We will all have to add yet > > > another #ifdef for this function, in the implementation or to define > > > php_dirname to keep the implementation clean(er). As it is good to > > > clean up codes, I'm not sure to remove this function is a good t

Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD

2008-03-05 Thread Pierre Joye
On Thu, Mar 6, 2008 at 1:32 AM, Lars Strojny <[EMAIL PROTECTED]> wrote: > Hi Pierre, > > Am Donnerstag, den 06.03.2008, 01:30 +0100 schrieb Pierre Joye: > [...] > > > I'm talking about extension developers. We will all have to add yet > > another #ifdef for this function, in the implementation o

Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD

2008-03-05 Thread Lars Strojny
Hi Pierre, Am Donnerstag, den 06.03.2008, 01:30 +0100 schrieb Pierre Joye: [...] > I'm talking about extension developers. We will all have to add yet > another #ifdef for this function, in the implementation or to define > php_dirname to keep the implementation clean(er). As it is good to > clean

Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD

2008-03-05 Thread Pierre Joye
On Thu, Mar 6, 2008 at 1:26 AM, Lars Strojny <[EMAIL PROTECTED]> wrote: > Hi Pierre, > > Am Donnerstag, den 06.03.2008, 01:22 +0100 schrieb Pierre Joye: > [...] > > > > 5_3: http://lars.schokokeks.org/php/5_3-deprecating-php_dirname.diff > > > HEAD: http://lars.schokokeks.org/php/HEAD-removing

Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD

2008-03-05 Thread Lars Strojny
Hi Pierre, Am Donnerstag, den 06.03.2008, 01:22 +0100 schrieb Pierre Joye: [...] > > 5_3: http://lars.schokokeks.org/php/5_3-deprecating-php_dirname.diff > > HEAD: http://lars.schokokeks.org/php/HEAD-removing-php_dirname.diff > > What's the gain of this change besides forcing code change and ad

Re: [PHP-DEV] Deprecating php_dirname() in 5_3, removing in HEAD

2008-03-05 Thread Pierre Joye
hi, On Thu, Mar 6, 2008 at 12:19 AM, Lars Strojny <[EMAIL PROTECTED]> wrote: > Hi, > > I would like to deprecate php_dirname() in 5_3 as it has been moved to > the engine (zend_dirname()). Any concerns? > > 5_3: http://lars.schokokeks.org/php/5_3-deprecating-php_dirname.diff > HEAD: http://lar