Re: [PHP-DEV] Coverity Scan

2011-08-09 Thread Joey Smith
On Tue, Aug 09, 2011 at 12:19:53AM -0700, Rasmus Lerdorf wrote: > On 08/08/2011 11:45 PM, Joey Smith wrote > > A lot of the 'STACK_USE' ones seem to be false positives; it's reporting > > when the stack "exceeds the maximum single use of 1024 bytes" - that 1024 > > is a Coverity-configurable value

Re: [PHP-DEV] Coverity Scan

2011-08-09 Thread Rasmus Lerdorf
On 08/08/2011 11:45 PM, Joey Smith wrote > A lot of the 'STACK_USE' ones seem to be false positives; it's reporting > when the stack "exceeds the maximum single use of 1024 bytes" - that 1024 > is a Coverity-configurable value which defaults to 1024. Yup, we can simply mark those as intentional/ig

Re: [PHP-DEV] Coverity Scan

2011-08-08 Thread Joey Smith
On Sat, Aug 06, 2011 at 08:07:01PM -0700, Rasmus Lerdorf wrote: > Coverity has run a new scan of trunk and there are a lot of valid > issues. You have probably noticed that I have started to fix some of > them, but there are 500+ to go, so I could use some help. The following > people already have

Re: [PHP-DEV] Coverity Scan

2011-08-08 Thread Ilia Alshanetsky
Scott, I've looked through most of the changes (some are even mine ;-) ) and they seem to be fairly harmless initialization tweaks etc... As it stands I think we should be in good shape to package 5.3.7 on Wed and finally get it out of the door. On Mon, Aug 8, 2011 at 3:18 AM, Scott MacVicar wro

Re: [PHP-DEV] Coverity Scan

2011-08-08 Thread Scott MacVicar
On 6 Aug 2011, at 20:07, Rasmus Lerdorf wrote: > Coverity has run a new scan of trunk and there are a lot of valid > issues. You have probably noticed that I have started to fix some of > them, but there are 500+ to go, so I could use some help. The following > people already have Coverity account