Re: [PHP-DEV] Const-correctness

2008-08-03 Thread Moriyoshi Koizumi
Marcus Boerger wrote: Overall you do a ton of 'struct * const var' which only means that you are going to copy the pointer explicitly. Now functions that use a pointer in a loop and increment it cannot optimize the code anymore and are forced to use an additional real variable on the stack. So un

Re: [PHP-DEV] Const-correctness

2008-08-03 Thread Felipe Pena
Hello Marcus, Em Dom, 2008-08-03 às 18:46 +0200, Marcus Boerger escreveu: > Index: Zend/zend.c > === > -static void print_hash(HashTable *ht, int indent, zend_bool is_object > TSRMLS_DC) /* {{{ */ > +static void print_hash(HashTable

Re: [PHP-DEV] Const-correctness

2008-08-03 Thread Marcus Boerger
Hello Felipe, Sunday, August 3, 2008, 3:12:01 PM, you wrote: > Hi all, > I made a patch that add the const qualifier in several function > parameters in Zend/* where it seems suitable (mostly the API). > http://felipe.ath.cx/diff/const-ness.diff (5_3) > HEAD comming soon in case of no objectio