Re: [PHP-DEV] Consensus gathering: allowing unsetting of backed property hooks

2025-02-26 Thread Ilija Tovilo
On Wed, Feb 26, 2025 at 2:02 PM Rob Landers wrote: > > I do think it makes sense to have an unset hook though, so long as it is > thought out well. For example, would the unset hook be called automatically > during garbage collection? I would be very wary of adding more ways for destruction to

Re: [PHP-DEV] Consensus gathering: allowing unsetting of backed property hooks

2025-02-26 Thread Rob Landers
On Wed, Feb 26, 2025, at 09:17, Rowan Tommins [IMSoP] wrote: > > > On 25 February 2025 23:31:25 GMT, tight.fork3...@fastmail.com wrote: > >On 2/25/25 4:51 PM, Rowan Tommins [IMSoP] wrote: > >> I actually started writing an RFC to rationalise some of this behaviour > > > >I'm glad I'm not the only

Re: [PHP-DEV] Consensus gathering: allowing unsetting of backed property hooks

2025-02-26 Thread Rowan Tommins [IMSoP]
On 25 February 2025 23:31:25 GMT, tight.fork3...@fastmail.com wrote: >On 2/25/25 4:51 PM, Rowan Tommins [IMSoP] wrote: >> I actually started writing an RFC to rationalise some of this behaviour > >I'm glad I'm not the only one who considers this an issue worth pursuing! Sorry, I wasn't clear: I

Re: [PHP-DEV] Consensus gathering: allowing unsetting of backed property hooks

2025-02-25 Thread tight . fork3192
> Most of the use cases you talk about are easily emulated from within > the class. If you're calling unset($foo->bar) from outside of the > class, I would argue the code is bad and needs to be rethought to begin > with. That may be so - we can judge the code PHP enables all we want, but the f

Re: [PHP-DEV] Consensus gathering: allowing unsetting of backed property hooks

2025-02-25 Thread Larry Garfield
On Tue, Feb 25, 2025, at 5:31 PM, tight.fork3...@fastmail.com wrote: > On 2/25/25 4:51 PM, Rowan Tommins [IMSoP] wrote: >> I actually started writing an RFC to rationalise some of this behaviour > > I'm glad I'm not the only one who considers this an issue worth pursuing! > >> Here are some of the

Re: [PHP-DEV] Consensus gathering: allowing unsetting of backed property hooks

2025-02-25 Thread tight . fork3192
On 2/25/25 4:51 PM, Rowan Tommins [IMSoP] wrote: > I actually started writing an RFC to rationalise some of this behaviour I'm glad I'm not the only one who considers this an issue worth pursuing! > Here are some of the things that might happen as a result of unset($foo->bar): I don't disagree t

Re: [PHP-DEV] Consensus gathering: allowing unsetting of backed property hooks

2025-02-25 Thread Rowan Tommins [IMSoP]
On 25/02/2025 21:13, tight.fork3...@fastmail.com wrote: Hello! I started GitHub issue requesting that property hooks be allowed to be `unset()`:https://github.com/php/php-src/issues/17922 While discussing in the issue it was suggested I pitch this to the mailing list, so here I am. Place me