Hey all,
Can we please reach a resolution on this?
- Davey
On Sun, Aug 7, 2016 at 9:04 AM, Davey Shafik wrote:
> AFAICT, to make this change, I'd have to modify:
>
> ZEND_API ZEND_COLD void zend_internal_type_error(zend_bool
> throw_exception, const char *format, ...) /* {{{ */
>
> To be:
>
>
AFAICT, to make this change, I'd have to modify:
ZEND_API ZEND_COLD void zend_internal_type_error(zend_bool throw_exception,
const char *format, ...) /* {{{ */
To be:
ZEND_API ZEND_COLD void zend_internal_type_error(zend_bool throw_exception,
zend_class_entry *zend_error, const char *format, …)
Hi!
> From: m...@kelunik.com>
> I don't like "ArgumentError", how about "WrongArgumentCountError"? Maybe
> also "WrongArgumentsError".
I'd favour simply ArgumentCountError. No need to prepend a "wrong" to theerror
class name - we can already guess it's wrong because it has resulted inan error
:
On Sat, Aug 6, 2016 at 11:53 AM, Davey Shafik wrote:
> On Sat, Aug 6, 2016 at 2:34 AM, Nikita Popov wrote:
>
>> On Sat, Aug 6, 2016 at 4:26 AM, Davey Shafik wrote:
>>
>>> Hey all,
>>>
>>> I know this is a little late in the process, but it's something I've
>>> noticed while prepping some conten
2016-08-06 11:53 GMT+02:00 Davey Shafik :
> On Sat, Aug 6, 2016 at 2:34 AM, Nikita Popov wrote:
>
> > On Sat, Aug 6, 2016 at 4:26 AM, Davey Shafik wrote:
> >
> >> Hey all,
> >>
> >> I know this is a little late in the process, but it's something I've
> >> noticed while prepping some content arou
On Sat, Aug 6, 2016 at 2:34 AM, Nikita Popov wrote:
> On Sat, Aug 6, 2016 at 4:26 AM, Davey Shafik wrote:
>
>> Hey all,
>>
>> I know this is a little late in the process, but it's something I've
>> noticed while prepping some content around 7.1.
>>
>> This RFC: https://wiki.php.net/rfc/too_few_a
On Sat, Aug 6, 2016 at 4:26 AM, Davey Shafik wrote:
> Hey all,
>
> I know this is a little late in the process, but it's something I've
> noticed while prepping some content around 7.1.
>
> This RFC: https://wiki.php.net/rfc/too_few_args
>
> Passed, and has been implemented, but I feel that throw
