Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4

2024-07-13 Thread Saki Takamachi
Hi Christoph, > 2024/07/13 22:30、Christoph M. Becker のメール: > > Hi Saki! > > On 13.07.2024 at 15:16, Saki Takamachi wrote: >> On 12.07.2024 at 17:26, Claude Pache wrote: See [1] and [2], which motivated the change. >>> >>> Ah, thank you! I probably should have checked this more

Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4

2024-07-13 Thread Christoph M. Becker
Hi Saki! On 13.07.2024 at 15:16, Saki Takamachi wrote: > >>> On 12.07.2024 at 17:26, Claude Pache wrote: >>> >>> See [1] and [2], which motivated the change. >> >> Ah, thank you! I probably should have checked this more thouroughly; >> now even I can see that there was a *bug*, so it is okay for

Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4

2024-07-13 Thread Saki Takamachi
Hi Christoph, > Hi! > >> On 12.07.2024 at 17:26, Claude Pache wrote: >> Le 12 juil. 2024 à 13:24, Christoph M. Becker a écrit : >>> >>> […] At the very least we should be sure that we want to keep >>> this change, and document it well, to avoid discussions in every filed >>> ticket. >>>

Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4

2024-07-13 Thread Christoph M. Becker
Hi! On 12.07.2024 at 17:26, Claude Pache wrote: > >> Le 12 juil. 2024 à 13:24, Christoph M. Becker a écrit : >> >> […] At the very least we should be sure that we want to keep >> this change, and document it well, to avoid discussions in every filed >> ticket. >> >> […] Thus, I think the change

Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4

2024-07-12 Thread Saki Takamachi
Hi Gina, > I agree, this situation is extremely suboptimal. > > My understanding as to why people declined the "Change the edge case of > round()" RFC [1] was because they were worried about the silent change in > behaviour. > However, most people seem to have missed the fact, myself included,

Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4

2024-07-12 Thread Claude Pache
> Le 12 juil. 2024 à 13:24, Christoph M. Becker a écrit : > > Hi all, > > there has been a "small" change in the rounding logic of > _php_math_round()[1] a couple of months ago. A respective ticket, > claiming the new behavior would be a bug[2] had been filed a while ago > without proper tria

Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4

2024-07-12 Thread Gina P. Banyard
On Friday, 12 July 2024 at 12:24, Christoph M. Becker wrote: > Hi all, > > there has been a "small" change in the rounding logic of > _php_math_round()[1] a couple of months ago. A respective ticket, > claiming the new behavior would be a bug[2] had been filed a while ago > without proper triage

Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4

2024-07-12 Thread Rob Landers
On Fri, Jul 12, 2024, at 13:24, Christoph M. Becker wrote: > Hi all, > > there has been a "small" change in the rounding logic of > _php_math_round()[1] a couple of months ago. A respective ticket, > claiming the new behavior would be a bug[2] had been filed a while ago > without proper triage so

Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4

2024-07-12 Thread Saki Takamachi
Hi Christoph, > Hi all, > > there has been a "small" change in the rounding logic of > _php_math_round()[1] a couple of months ago. A respective ticket, > claiming the new behavior would be a bug[2] had been filed a while ago > without proper triage so far. I'm bringing this to your attention,