Re: [PHP-DEV] Basic string comparison functions still use old parameter parsing API

2017-06-07 Thread Benjamin Coutu
Thanks for creating a pull request for this! == Original == From: Fleshgrinder To: php-internals , ben.co...@zeyos.com, Dmitry Stogov Date: Wed, 07 Jun 2017 21:29:56 +0200 Subject: Re: [PHP-DEV] Basic string comparison functions still use old parameter parsing API > On

Re: [PHP-DEV] Basic string comparison functions still use old parameter parsing API

2017-06-07 Thread Fleshgrinder
On 6/7/2017 7:15 PM, Benjamin Coutu wrote: > Hi Dmitry, > > I just noticed that all basic string comparison functions in > Zend/zend_builtin_functions.c, especially "strcmp", "strncmp", > "strcasecmp", "strncasecmp" still use the old and inefficient > parameter parsing API, unlike similar function