Re: [PHP-DEV] Base_convert changes

2023-06-30 Thread Marc
Hi, I noticed a deprecation of passing invalid characters to bindec since PHP 7.4 which is still deprecated and does not result in an error. Haven't checked the other affected functions of this RFC. https://3v4l.org/Bqj5B Is anyone taking care to remove this in 9.0? Thanks, Marc -- PHP In

Re: [PHP-DEV] Base_convert changes

2019-03-12 Thread Scott Dutton
On 11.03.2019 10:51, Nikita Popov wrote: Both changes sound reasonable to me. Could you show some examples where the output is going to change due to the zend_ulong->zend_long switch? Nikita Sure! For example var_dump(decbin(9223372036854775807)); would currently show string(64) "1

Re: [PHP-DEV] Base_convert changes

2019-03-11 Thread Nikita Popov
On Sun, Mar 10, 2019 at 1:29 PM Scott Dutton wrote: > Hi, > > I have just put a pull request together to make some changes to > base_convert, the changes are as follows: > > 1, Allow conversion of negative numbers (fixes > https://bugs.php.net/bug.php?id=55393) > 2, Raise a notice when passing in