Re: [PHP-DEV] BC break with callbacks in 5.3

2008-01-31 Thread Rasmus Lerdorf
Greg Beaver wrote: > Marcus Boerger wrote: >> Hello Scott, >> >> actually it was a bug. We, sorry I, did not spot this in earlier versions. >> Now saying you rely on a bug in PHP 5 to be able to execute PHP 4 code >> simply does not work. > > Hi Marcus, > > How is forcing users to replace call_

Re: [PHP-DEV] BC break with callbacks in 5.3

2008-01-31 Thread Greg Beaver
Marcus Boerger wrote: Hello Scott, actually it was a bug. We, sorry I, did not spot this in earlier versions. Now saying you rely on a bug in PHP 5 to be able to execute PHP 4 code simply does not work. Hi Marcus, How is forcing users to replace call_user_func(array('Classname', 'func')) w

Re: [PHP-DEV] BC break with callbacks in 5.3

2008-01-30 Thread Chuck Hagenbuch
Quoting Marcus Boerger <[EMAIL PROTECTED]>: actually it was a bug. We, sorry I, did not spot this in earlier versions. Now saying you rely on a bug in PHP 5 to be able to execute PHP 4 code simply does not work. The bug is that with callbacks in PHP 5.3+, E_STRICT is enforced even when E_S

Re: [PHP-DEV] BC break with callbacks in 5.3

2008-01-30 Thread Scott MacVicar
Marcus, I fully agree that you should add static keywords if you intend to call a method statically, but it's not always possible. Some people are still maintaing a code base that runs in both PHP 4 and 5 without any significant changes. The other problem here is inconsistency, I can call th

Re: [PHP-DEV] BC break with callbacks in 5.3

2008-01-30 Thread Antony Dovgal
On 30.01.2008 18:06, Marcus Boerger wrote: > Hello Scott, > > actually it was a bug. We, sorry I, did not spot this in earlier versions. > Now saying you rely on a bug in PHP 5 to be able to execute PHP 4 code > simply does not work. I believe the bug was to make non-static methods to behave di

Re: [PHP-DEV] BC break with callbacks in 5.3

2008-01-30 Thread Marcus Boerger
Hello Scott, actually it was a bug. We, sorry I, did not spot this in earlier versions. Now saying you rely on a bug in PHP 5 to be able to execute PHP 4 code simply does not work. marcus Wednesday, January 30, 2008, 11:48:50 AM, you wrote: > Hi all, > Static callbacks behave differently bet

Re: [PHP-DEV] BC break with callbacks in 5.3

2008-01-30 Thread Scott MacVicar
Hi, If you could rename IS_CALLABLE_CHECK_NO_ACCESS too that would be great, at first glance I expected it to check access on the callback. In reality its to skip the access check, so might be worth checking from a clarity point of view. IS_CALLABLE_SKIP_ACCESS_CHECK or IS_CALLABLE_ACCESS_CH

Re: [PHP-DEV] BC break with callbacks in 5.3

2008-01-30 Thread Etienne Kneuss
Hi, I planned to do some various callbacks related cleanups on 5_3. If that's ok with you, I'll come with a patch within the following days that should fix various issues, including your patch if still necessary. Regards On Jan 30, 2008 11:48 AM, Scott MacVicar <[EMAIL PROTECTED]> wrote: > Hi al