Re: [PHP-DEV] Avoiding enum reserved keyword

2021-03-06 Thread Ilija Tovilo
Hi Nikita > Another possibility would be to recognize T_ENUM in the lexer, but only if > it is followed by whitespace and an identifier. This would possibly be > friendlier for tooling using token_get_all(). It would not permit comments > in between the tokens though. Thanks for the suggestion. T

Re: [PHP-DEV] Avoiding enum reserved keyword

2021-02-23 Thread Matthew Brown
On Tue, 23 Feb 2021 at 06:21, Nikita Popov wrote: > Another possibility would be to recognize T_ENUM in the lexer, but only if > it is followed by whitespace and an identifier. This would possibly be > friendlier for tooling using token_get_all(). It would not permit comments > in between the tok

Re: [PHP-DEV] Avoiding enum reserved keyword

2021-02-23 Thread Larry Garfield
On Tue, Feb 23, 2021, at 5:21 AM, Nikita Popov wrote: > Hi internals, > > I'm a bit concerned about the addition of the "enum" reserved keyword as > part of https://wiki.php.net/rfc/enumerations. The problem is that there > are quite a few existing enum libraries (such as > https://github.com/mycl