Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-17 Thread Pierrick Charron
Oh sorry I'm gonna do it right now. Thanks :) On 17 April 2013 18:02, Hannes Magnusson wrote: > I think by law you have to create a new thread and prefix the subject > line with [VOTE] or something. > > -Hannes > > On Wed, Apr 17, 2013 at 2:59 PM, Pierrick Charron > wrote: > > Hi, > > > > Sin

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-17 Thread Hannes Magnusson
I think by law you have to create a new thread and prefix the subject line with [VOTE] or something. -Hannes On Wed, Apr 17, 2013 at 2:59 PM, Pierrick Charron wrote: > Hi, > > Since we are in a tight schedule, I started the vote and it will end in a > week. > > https://wiki.php.net/rfc/curl-wrap

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-17 Thread Pierrick Charron
Hi, Since we are in a tight schedule, I started the vote and it will end in a week. https://wiki.php.net/rfc/curl-wrappers-removal-rfc#vote Pierrick On 16 April 2013 09:17, Julien Pauli wrote: > On Tue, Apr 16, 2013 at 3:01 PM, Pierrick Charron wrote: > >> I created a straightforward RFC tha

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-16 Thread Julien Pauli
On Tue, Apr 16, 2013 at 3:01 PM, Pierrick Charron wrote: > I created a straightforward RFC that you can access here > https://wiki.php.net/rfc/curl-wrappers-removal-rfc . > > If someone have something more to add in it, feel free. Otherwise I will > start the vote so that we could remove it in 5.

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-16 Thread Pierrick Charron
I created a straightforward RFC that you can access here https://wiki.php.net/rfc/curl-wrappers-removal-rfc . If someone have something more to add in it, feel free. Otherwise I will start the vote so that we could remove it in 5.5 ASAP. Thanks Pierrick On 12 April 2013 11:09, Julien Pauli wrot

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Stas Malyshev
Hi! > I don't know who suggested getting rid of it in 5.3 or 5.4, that is > ofcourse seriously stupid thing to do. > The original request was to kill it dead in 5.5, and remove the > constant again from 5.3 and 5.4. OK, I agree with that. I think origination of this was Pierre's comment to apply

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Hannes Magnusson
On Fri, Apr 12, 2013 at 2:00 PM, Stas Malyshev wrote: > Hi! > >> 5.3 users might depend on some part of the behavior and have learned to >> live with bugs. We shouldn't kick "features" at this stage. > > I agree, for 5.4 too. We had it for a long time, and however buggy or > broken it is, there mi

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Stas Malyshev
Hi! > 5.3 users might depend on some part of the behavior and have learned to > live with bugs. We shouldn't kick "features" at this stage. I agree, for 5.4 too. We had it for a long time, and however buggy or broken it is, there might be people that use it, and stable version implies promise the

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Julien Pauli
On Fri, Apr 12, 2013 at 4:09 PM, David Soria Parra wrote: > On 2013-04-12, Johannes Schlüter wrote: > > 5.3 users might depend on some part of the behavior and have learned to > > live with bugs. We shouldn't kick "features" at this stage. > > curlwrappers should definatly stay in 5.3 and 5.4. I

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread David Soria Parra
On 2013-04-12, Johannes Schl�ter wrote: > 5.3 users might depend on some part of the behavior and have learned to > live with bugs. We shouldn't kick "features" at this stage. curlwrappers should definatly stay in 5.3 and 5.4. I have no problem with having them removed in 5.5 (with an RFC) but I

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Pierrick Charron
+1 On 12 April 2013 04:07, Johannes Schlüter wrote: > On Fri, 2013-04-12 at 10:00 +0200, Julien Pauli wrote: > > On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen > wrote: > > > > > Hi > > > > > > 2013/4/12 Pierre Joye : > > > > On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron < > pierr..

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Pierre Joye
On Fri, Apr 12, 2013 at 10:07 AM, Johannes Schlüter wrote: > On Fri, 2013-04-12 at 10:00 +0200, Julien Pauli wrote: >> On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen wrote: >> >> > Hi >> > >> > 2013/4/12 Pierre Joye : >> > > On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron >> > wrote: >

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Johannes Schlüter
On Fri, 2013-04-12 at 10:00 +0200, Julien Pauli wrote: > On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen wrote: > > > Hi > > > > 2013/4/12 Pierre Joye : > > > On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron > > wrote: > > >> Including 5.3 and 5.4 ?? > > > > If removed in 5.3 and 5.4, th

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Xinchen Hui
On Fri, Apr 12, 2013 at 4:00 PM, Julien Pauli wrote: > On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen wrote: > >> Hi >> >> 2013/4/12 Pierre Joye : >> > On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron >> wrote: >> >> Including 5.3 and 5.4 ?? >> >> If removed in 5.3 and 5.4, theres no ne

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-12 Thread Julien Pauli
On Fri, Apr 12, 2013 at 1:34 AM, Kalle Sommer Nielsen wrote: > Hi > > 2013/4/12 Pierre Joye : > > On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron > wrote: > >> Including 5.3 and 5.4 ?? > > If removed in 5.3 and 5.4, theres no need for the constant anymore. > Right :-) I agree with Pierre as

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Kalle Sommer Nielsen
Hi 2013/4/12 Pierre Joye : > On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron wrote: >> Including 5.3 and 5.4 ?? If removed in 5.3 and 5.4, theres no need for the constant anymore. -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Mailing List To un

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Pierre Joye
On Thu, Apr 11, 2013 at 11:17 PM, Pierrick Charron wrote: > Including 5.3 and 5.4 ?? Yes, why should we have it there? Either it is stable and ready or it is not (as it is now). -- Pierre @pierrejoye -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Pierrick Charron
Including 5.3 and 5.4 ?? Pierrick On 11 April 2013 14:12, Pierre Joye wrote: > On Thu, Apr 11, 2013 at 4:54 PM, Pierrick Charron > wrote: > > If you decide to remove it for 5.5 RC, tell me and I'll merge this branch > > https://github.com/adoy/php-src/tree/remove-curl-wrappers > > s,5.5,all br

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Pierre Joye
On Thu, Apr 11, 2013 at 4:54 PM, Pierrick Charron wrote: > If you decide to remove it for 5.5 RC, tell me and I'll merge this branch > https://github.com/adoy/php-src/tree/remove-curl-wrappers s,5.5,all branches, Cheers, -- Pierre @pierrejoye -- PHP Internals - PHP Runtime Development Mailin

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Pierrick Charron
If you decide to remove it for 5.5 RC, tell me and I'll merge this branch https://github.com/adoy/php-src/tree/remove-curl-wrappers Thanks Pierrick On 11 April 2013 04:03, Julien Pauli wrote: > On Wed, Apr 10, 2013 at 6:52 PM, Pierre Joye wrote: > >> On Wed, Apr 10, 2013 at 6:46 PM, Julien Pau

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Kalle Sommer Nielsen
Hi Julien 2013/4/11 Julien Pauli : > Ok, too bad we taggued beta3 with it. I suggest we remove this feature when > going RC so. Huge +1 -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Xinchen Hui
On Thu, Apr 11, 2013 at 4:03 PM, Julien Pauli wrote: > On Wed, Apr 10, 2013 at 6:52 PM, Pierre Joye wrote: > >> On Wed, Apr 10, 2013 at 6:46 PM, Julien Pauli wrote: >> >> > Beta3 has been taggued with curl wrappers, and with the new >> > CURL_WRAPPERS_ENABLED constant :-p >> > >> > Do we all ag

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-11 Thread Julien Pauli
On Wed, Apr 10, 2013 at 6:52 PM, Pierre Joye wrote: > On Wed, Apr 10, 2013 at 6:46 PM, Julien Pauli wrote: > > > Beta3 has been taggued with curl wrappers, and with the new > > CURL_WRAPPERS_ENABLED constant :-p > > > > Do we all agree to remove that feature (meaning moving it to a branch, or >

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-10 Thread Pierre Joye
On Wed, Apr 10, 2013 at 6:46 PM, Julien Pauli wrote: > Beta3 has been taggued with curl wrappers, and with the new > CURL_WRAPPERS_ENABLED constant :-p > > Do we all agree to remove that feature (meaning moving it to a branch, or > somewhere for the interested developers to keep on making it stab

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-10 Thread Julien Pauli
On Fri, Apr 5, 2013 at 8:54 PM, Hannes Magnusson wrote: > On Fri, Apr 5, 2013 at 7:14 AM, Julien Pauli wrote: > > On Fri, Apr 5, 2013 at 12:51 PM, Johannes Schlüter < > johan...@schlueters.de> > > wrote: > >> > >> On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote: > >> > > stream_wrapper_unre

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-05 Thread Hannes Magnusson
On Fri, Apr 5, 2013 at 7:14 AM, Julien Pauli wrote: > On Fri, Apr 5, 2013 at 12:51 PM, Johannes Schlüter > wrote: >> >> On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote: >> > > stream_wrapper_unregister("http"); >> > > stream_wrapper_register("http", "CurlStreamWrapper"); >> > > and then stre

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-05 Thread Julien Pauli
On Fri, Apr 5, 2013 at 12:51 PM, Johannes Schlüter wrote: > On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote: > > > stream_wrapper_unregister("http"); > > > stream_wrapper_register("http", "CurlStreamWrapper"); > > > and then stream_wrapper_restore("http") to go back to the core > > streams. >

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-05 Thread Johannes Schlüter
On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote: > > stream_wrapper_unregister("http"); > > stream_wrapper_register("http", "CurlStreamWrapper"); > > and then stream_wrapper_restore("http") to go back to the core > streams. > > > > I wonder what one will do with open streams during the switch

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-05 Thread Julien Pauli
On Fri, Apr 5, 2013 at 8:01 AM, Pierre Joye wrote: > On Thu, Apr 4, 2013 at 9:52 PM, Hannes Magnusson > wrote: > > > Its not only about maintaining it. > > This experiment failed a long time ago. Overwriting the core streams > > has proven itself to be the wrong way. > > I cannot agree more. > >

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-04 Thread Pierre Joye
On Thu, Apr 4, 2013 at 9:52 PM, Hannes Magnusson wrote: > Its not only about maintaining it. > This experiment failed a long time ago. Overwriting the core streams > has proven itself to be the wrong way. I cannot agree more. > If there was a way for userspace to say "overload with curl" then t

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-04 Thread Kalle Sommer Nielsen
2013/4/4 Hannes Magnusson : > stream_wrapper_unregister("http"); > stream_wrapper_register("http", "CurlStreamWrapper"); > and then stream_wrapper_restore("http") to go back to the core streams. If we alter curlwrappers to work like that, then it could stay, and since this is an experimental featu

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-04 Thread Hannes Magnusson
On Thu, Apr 4, 2013 at 11:27 AM, Pierrick Charron wrote: > Hi > > I don't think we should remove curlwrappers from 5.5. I do agree that this > is not yet stable and ready to push as non experimental, but since we plan > to release 5.5 soon I don't think removing it right now is worth it. > > I sta

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-04 Thread Pierrick Charron
Hi I don't think we should remove curlwrappers from 5.5. I do agree that this is not yet stable and ready to push as non experimental, but since we plan to release 5.5 soon I don't think removing it right now is worth it. I started some time ago to maintain the curl extension. I focused mainly on

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-04 Thread Julien Pauli
IMO , we should remove that feature from 5.5. If Laruence is OK to maintain it, then we keep it, but Laruence, please, improve it so. We keep it if Laruence can make it stable for 5.5 final. If he cant , or doesn't want to work on it any more while in betas ; then we should remove curlwrapper from

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-04 Thread Xinchen Hui
发自我的 iPhone 在 2013-4-4,16:36,Leigh 写道: I find this somewhat conflicting. If it's experimental, and will likely be removed because nobody will maintain it, why is anything being added to it at all? Maintaining it. This simply makes it easier for people to build a dependance on a feature that

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-04 Thread Leigh
I find this somewhat conflicting. If it's experimental, and will likely be removed because nobody will maintain it, why is anything being added to it at all? This simply makes it easier for people to build a dependance on a feature that will ultimately cease to exist in the next major version. I

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Laruence
On Thu, Apr 4, 2013 at 1:39 PM, Levi Morrison wrote: > Did I just read that even though we have reasons to believe this is not a > good addition that we are *still* going to launch 5.5 with it? > where did you read that(not a good addition)? thanks -- Laruence Xinchen Hui http://www.laruence.

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Levi Morrison
Did I just read that even though we have reasons to believe this is not a good addition that we are *still* going to launch 5.5 with it?

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Laruence
On Thu, Apr 4, 2013 at 5:37 AM, Hannes Magnusson wrote: > On Wed, Apr 3, 2013 at 2:00 PM, Stas Malyshev > wrote: > > Hi! > > > >> There is absolutely no need for a RFC for it. > >> Heck, even that initial curtesy mail was more then I would have > expected. > > > > Agree, no need for full scale R

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Ferenc Kovacs
On Wed, Apr 3, 2013 at 10:42 PM, Hannes Magnusson < hannes.magnus...@gmail.com> wrote: > On Wed, Apr 3, 2013 at 5:42 AM, Ferenc Kovacs wrote: > > On Wed, Apr 3, 2013 at 10:37 AM, Laruence wrote: > > > > >> however, you are right, it's not a long time, so if objections > becomes > >> strong,

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Hannes Magnusson
On Wed, Apr 3, 2013 at 2:00 PM, Stas Malyshev wrote: > Hi! > >> There is absolutely no need for a RFC for it. >> Heck, even that initial curtesy mail was more then I would have expected. > > Agree, no need for full scale RFC for one constant. However, sending an > email to the list and actually wa

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Stas Malyshev
Hi! > There is absolutely no need for a RFC for it. > Heck, even that initial curtesy mail was more then I would have expected. Agree, no need for full scale RFC for one constant. However, sending an email to the list and actually waiting for feedback is exactly what I would expect, especially de

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Hannes Magnusson
On Wed, Apr 3, 2013 at 5:42 AM, Ferenc Kovacs wrote: > On Wed, Apr 3, 2013 at 10:37 AM, Laruence wrote: > >> however, you are right, it's not a long time, so if objections becomes >> strong, I can revert it. >> > > this is exactly the kind of behavior why we changed from the commit first >

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Kalle Sommer Nielsen
Hi 2013/4/3 Laruence : > Hey: >but as you see, many people was entrapped by the experimental feature, > and whether the experimental is there is out of their hands. > >I, from a user aspect, I need to know whether my project can run in the > host environment. if not, I can warn the use

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Laruence
On Wed, Apr 3, 2013 at 10:42 PM, Kalle Sommer Nielsen wrote: > 2013/4/3 Laruence : > > On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev >wrote: > > > >> Hi! > >> > >> > Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) > >> > > >> > https://github.com/php/php-src/commit/d7f709a032a40cb47504

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Kalle Sommer Nielsen
2013/4/3 Laruence : > On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev wrote: > >> Hi! >> >> > Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) >> > >> https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7 >> >> I must say the process of how it was done was not very g

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Xinchen Hui
发自我的 iPhone 在 2013-4-3,20:42,Ferenc Kovacs 写道: On Wed, Apr 3, 2013 at 10:37 AM, Laruence wrote: > On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev >wrote: > > > Hi! > > > > > Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) > > > > > > https://github.com/php/php-src/commit/d7f709a032

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Ferenc Kovacs
On Wed, Apr 3, 2013 at 10:37 AM, Laruence wrote: > On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev >wrote: > > > Hi! > > > > > Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) > > > > > > https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7 > > > > I must say the

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Pierre Joye
On Wed, Apr 3, 2013 at 10:22 AM, Stas Malyshev wrote: > Hi! > >> Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) >> https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7 > > I must say the process of how it was done was not very good. Not only > there were no sub

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Laruence
On Wed, Apr 3, 2013 at 4:22 PM, Stas Malyshev wrote: > Hi! > > > Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) > > > https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7 > > I must say the process of how it was done was not very good. Not only > there were no

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Stas Malyshev
Hi! > Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) > https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7 I must say the process of how it was done was not very good. Not only there were no substantial discussion on adding this new thing in stable version be

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Kalle Sommer Nielsen
2013/4/3 Hannes Magnusson : > You'll actually have to assign the value of CURL_WRAPPERS_ENABLED to > $curlwrappers, as defined() only checks if the constant exist.. not if > its set to true :) well, s/defined('CURL_WRAPPERS_ENABLED')/defined('CURL_WRAPPERS_ENABLED') && CURL_WRAPPERS_ENABLED/ Doe

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Hannes Magnusson
On Wed, Apr 3, 2013 at 12:31 AM, Kalle Sommer Nielsen wrote: > Hi Laruence > > 2013/3/31 Laruence >>I propose to add a constant : bool CURL_WRAPPERS_ENABLE >> >>or, any other better name... >> >>objections? > > I'm a -1 on this, because as we sort of agreed on (like Hannes > implied),

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-03 Thread Kalle Sommer Nielsen
Hi Laruence 2013/3/31 Laruence >I propose to add a constant : bool CURL_WRAPPERS_ENABLE > >or, any other better name... > >objections? I'm a -1 on this, because as we sort of agreed on (like Hannes implied), this experimental feature did not turn out as we wanted, its buggy and nobod

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-02 Thread Ferenc Kovacs
On Wed, Apr 3, 2013 at 8:10 AM, Xinchen Hui wrote: > 发自我的 iPhone > > 在 2013-4-3,13:56,Hannes Magnusson 写道: > > > Wait wait wait. You are introducing a constant that is going to be > > available as of 5.4.15 to 5.4.2x and then removed (as it looks like we > > are agreeing)? > how could that be?

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-02 Thread Xinchen Hui
发自我的 iPhone 在 2013-4-3,13:56,Hannes Magnusson 写道: > Wait wait wait. You are introducing a constant that is going to be > available as of 5.4.15 to 5.4.2x and then removed (as it looks like we > are agreeing)? how could that be? This constant will in the final release of 5.5.0. Thanks > > Peopl

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-02 Thread Hannes Magnusson
Wait wait wait. You are introducing a constant that is going to be available as of 5.4.15 to 5.4.2x and then removed (as it looks like we are agreeing)? People have been living without this constant forever now so people have their workarounds in place and no need to complicate their code to for t

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-02 Thread Laruence
Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7 thanks On Mon, Apr 1, 2013 at 9:53 PM, Laruence wrote: > > > > On Mon, Apr 1, 2013 at 7:18 AM, Hannes Magnusson < > hannes.magnus...@gmail.com> wrote: > >> O

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-01 Thread Laruence
On Mon, Apr 1, 2013 at 7:18 AM, Hannes Magnusson wrote: > On Sun, Mar 31, 2013 at 6:25 AM, Laruence wrote: > > Hey: > > > >there are some issues when people run some codes in a php which is > > compiled with --with-curlwrappers, like #61336, or the recently test > script > > for #64433 (fail

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-01 Thread Jordi Boggiano
On 01.04.2013 01:18, Hannes Magnusson wrote: >>I propose to add a constant : bool CURL_WRAPPERS_ENABLE +1 on a constant if it has to stay. We had to do pretty ugly stuff to detect it in the composer installer https://github.com/composer/getcomposer.org/blob/master/web/installer#L135-148 > The

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-01 Thread Pierre Joye
On Mon, Apr 1, 2013 at 10:17 AM, Madara Uchiha wrote: > I actually agree with that. I've reached a point when I consider using > fsockopen instead of curl to fetch information from a website. I can > hardly stand cURL. Curl stream wrappers and ext/curl are two different things. ext/curl APIs is q

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-04-01 Thread Madara Uchiha
I actually agree with that. I've reached a point when I consider using fsockopen instead of curl to fetch information from a website. I can hardly stand cURL. There should be a decent OOP based wrapper for making HTTP requests to handle it decently. Meanwhile, I agree that cURL needs to go. On Mo

Re: [PHP-DEV] Add a constant to reflect --with-curlwrappers

2013-03-31 Thread Hannes Magnusson
On Sun, Mar 31, 2013 at 6:25 AM, Laruence wrote: > Hey: > >there are some issues when people run some codes in a php which is > compiled with --with-curlwrappers, like #61336, or the recently test script > for #64433 (failed when curl wrappers enabled). > >I know, that the curl wrapper sho