Re: [PHP-DEV] [VOTE] str_icontains

2025-07-01 Thread youkidearitai
Hi, Adam, and internals I don't have a authority of vote. But I don't think make sense to support case-insensitive only ASCII of str_contains. Because it benefit is only ASCII region. I want to also supports Unicode case-insensitive for str_starts_with and str_ends_with. I'm glad to discuss to im

Re: [PHP-DEV] [VOTE] str_icontains

2025-07-01 Thread Derick Rethans
On Tue, 1 Jul 2025, Adam Cable wrote: > Hi, > > Voting just opened on the "str_icontains" RFC. > > Please find the following resources: > > RFC: https://wiki.php.net/rfc/str_icontains > Discussion: https://externals.io/message/127667 > PR: https://github.com/php/php-src/pull/18705 > > As with

Re: [PHP-DEV] [VOTE] str_icontains

2025-07-01 Thread Tim Düsterhus
Hi Am 2025-07-01 10:17, schrieb Adam Cable: Thanks for giving an explanation of your vote, thank you. I had assumed that going with a small RFC for this would be easier than trying to get str_starts/ends_with through at the same time, as noted in the PR: "I'll create a RFC for this, and if su

Re: [PHP-DEV] [VOTE] str_icontains

2025-07-01 Thread Andreas Heigl
Hey Adam Am 01.07.25 um 09:01 schrieb Adam Cable: Hi, Voting just opened on the "str_icontains" RFC. I have also voted *no* on this RFC for 2 reasons. 1. I also think that - if we go that route - the other convenience functions around strpos need to be taken into account here as well. 2.

Re: [PHP-DEV] [VOTE] str_icontains

2025-07-01 Thread Adam Cable
On Tue, Jul 1, 2025 at 8:24 AM Tim Düsterhus wrote: > Hi > > Am 2025-07-01 09:01, schrieb Adam Cable: > > Voting just opened on the "str_icontains" RFC. > > > > Please find the following resources: > > > > RFC: https://wiki.php.net/rfc/str_icontains > > Discussion: https://externals.io/message/12

Re: [PHP-DEV] [VOTE] str_icontains

2025-07-01 Thread Tim Düsterhus
Hi Am 2025-07-01 09:01, schrieb Adam Cable: Voting just opened on the "str_icontains" RFC. Please find the following resources: RFC: https://wiki.php.net/rfc/str_icontains Discussion: https://externals.io/message/127667 PR: https://github.com/php/php-src/pull/18705 Thank you for your RFC. Wh