Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-26 Thread Christoph M. Becker
On 25.09.2016 at 14:20, Dan Ackroyd wrote: > On 25 September 2016 at 06:29, Pierre Joye wrote: > >> I am pretty sure it is by design (for what I can remember) > > I do not believe that is correct. > > The commit message* says: "Restore PHP-5.2 behaviour when passing null > inside object scope

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-26 Thread Dan Ackroyd
> On 26 Sep 2016, at 10:20, Pierre Joye wrote: > I think it is > clear now that this behavior is by design No it is not. You ignored my previous email which showed the commit message doesn't do what it says. The code doesn't do what it says in the manual either. If you're not going to read f

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-26 Thread Pierre Joye
On Mon, Sep 26, 2016 at 4:06 AM, Niklas Keller wrote: > 2016-09-25 20:58 GMT+02:00 Pierre Joye : >> All I am saying is this is a BC break with little to no value because what >> willing to support 7.1+ only can simply use the alternatives. > > Which alternatives? Wrong wording. In any case this

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-25 Thread Niklas Keller
2016-09-25 20:58 GMT+02:00 Pierre Joye : > On Sep 26, 2016 12:09 AM, "Niklas Keller" wrote: > > > > 2016-09-25 15:19 GMT+02:00 Christoph M. Becker : > >> > >> On 25.09.2016 at 11:29, Leigh wrote: > >> > >> > On Sun, 25 Sep 2016 at 06:29 Pierre Joye > wrote: > >> > > >> >> Also this behavior is c

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-25 Thread Pierre Joye
On Sep 26, 2016 12:09 AM, "Niklas Keller" wrote: > > 2016-09-25 15:19 GMT+02:00 Christoph M. Becker : >> >> On 25.09.2016 at 11:29, Leigh wrote: >> >> > On Sun, 25 Sep 2016 at 06:29 Pierre Joye wrote: >> > >> >> Also this behavior is clearly documented: >> >> >> >> http://th1.php.net/manual/en/fu

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-25 Thread Niklas Keller
2016-09-25 15:19 GMT+02:00 Christoph M. Becker : > On 25.09.2016 at 11:29, Leigh wrote: > > > On Sun, 25 Sep 2016 at 06:29 Pierre Joye wrote: > > > >> Also this behavior is clearly documented: > >> > >> http://th1.php.net/manual/en/function.get-class.php > >> > >> "If object is omitted when insid

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-25 Thread Christoph M. Becker
On 25.09.2016 at 11:29, Leigh wrote: > On Sun, 25 Sep 2016 at 06:29 Pierre Joye wrote: > >> Also this behavior is clearly documented: >> >> http://th1.php.net/manual/en/function.get-class.php >> >> "If object is omitted when inside a class, the name of that class is >> returned." >> >> I am oppo

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-25 Thread Pierre Joye
On Sep 25, 2016 4:29 PM, "Leigh" wrote: > > > > On Sun, 25 Sep 2016 at 06:29 Pierre Joye wrote: >> >> Also this behavior is clearly documented: >> >> http://th1.php.net/manual/en/function.get-class.php >> >> "If object is omitted when inside a class, the name of that class is >> returned." >> >>

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-25 Thread Dan Ackroyd
On 25 September 2016 at 06:29, Pierre Joye wrote: > I am pretty sure it is by design (for what I can remember) I do not believe that is correct. The commit message* says: "Restore PHP-5.2 behaviour when passing null inside object scope to get_class()" The commit does not restore the previous b

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-25 Thread Leigh
On Sun, 25 Sep 2016 at 06:29 Pierre Joye wrote: > Also this behavior is clearly documented: > > http://th1.php.net/manual/en/function.get-class.php > > "If object is omitted when inside a class, the name of that class is > returned." > > I am opposed to break BC because we change our mind about h

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-24 Thread Pierre Joye
Hi On Sep 24, 2016 6:02 PM, "Dan Ackroyd" wrote: > > Hi, > > I'm going to put the 'get_class() disallow null parameter' RFC to a > vote: https://wiki.php.net/rfc/get_class_disallow_null_parameter > > I realise that some people might prefer to have it target 8.0, rather > than 7.2. While I appreci