Re: [PHP-DEV] [VOTE] Use exceptions by default in SQLite3 extension

2023-05-23 Thread BohwaZ
Voting has now ended with 21 votes for the "yes", and zero votes for the "no". Thanks everyone! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] Use exceptions by default in SQLite3 extension

2023-05-15 Thread someniatko
Got it, thank you for explaining. Regards, Illia / someniatko -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] Use exceptions by default in SQLite3 extension

2023-05-15 Thread G. P. B.
On Mon, 15 May 2023 at 15:41, someniatko wrote: > The `PDOException` class is actually extending the `RuntimeException`, > not just `Exception`. > Yes, and this is, IMHO, a mistake. Outside SPL, there are only 4 extensions which extend from RuntimeException: - PDO - MySQLi - SNMP - Phar See

Re: [PHP-DEV] [VOTE] Use exceptions by default in SQLite3 extension

2023-05-15 Thread BohwaZ
Hi Illia, thank you for your feedback. This is actually what I did, first, but I changed after feedback from @Girgias: https://github.com/php/php-src/pull/11058#discussion_r1162723112 > You are likely to get push back not just from myself if you propose > it as such in an RFC I don't have a st

Re: [PHP-DEV] [VOTE] Use exceptions by default in SQLite3 extension

2023-05-15 Thread someniatko
Hi! It says in the RFC: > PDO is using exceptions, like everyone else. and > Create a new exception class SQLite3Exception, which extends the Exception > class The `PDOException` class is actually extending the `RuntimeException`, not just `Exception`. I am sure it is better to do this for `S