Re: [PHP-DEV] [VOTE] Add IntlDatePatternGenerator

2021-05-31 Thread Mel Dafert
>Right, for the purposes of this RFC, it's okay to just drop them if there >are no objections. A general policy RFC may still be useful for future >reference. In that case, I will just go ahead and remove the procedural style from my implementation (unless someone speaks up and objects). I will mo

Re: [PHP-DEV] [VOTE] Add IntlDatePatternGenerator

2021-05-31 Thread Nikita Popov
On Sat, May 29, 2021 at 4:25 PM Christoph M. Becker wrote: > On 29.05.2021 at 10:02, Mel Dafert wrote: > > >> Agreed with Nikita. There's no compelling reason to add double-API > style anymore. It may take a second RFC to modify this one to remove > those, technically, but I'd vote for it. > >

Re: [PHP-DEV] [VOTE] Add IntlDatePatternGenerator

2021-05-29 Thread Christoph M. Becker
On 29.05.2021 at 10:02, Mel Dafert wrote: >> Agreed with Nikita. There's no compelling reason to add double-API style >> anymore. It may take a second RFC to modify this one to remove those, >> technically, but I'd vote for it. > > Should this new RFC then only apply to IntlDatePatternGenerato

Re: [PHP-DEV] [VOTE] Add IntlDatePatternGenerator

2021-05-29 Thread Mel Dafert
>Agreed with Nikita. There's no compelling reason to add double-API style >anymore. It may take a second RFC to modify this one to remove those, >technically, but I'd vote for it. Should this new RFC then only apply to IntlDatePatternGenerator, or should it also clarify that future additions

Re: [PHP-DEV] [VOTE] Add IntlDatePatternGenerator

2021-05-28 Thread Larry Garfield
On Fri, May 28, 2021, at 5:52 PM, Mel Dafert wrote: > >It's ... checks calendar ... the year 2021. Do we *really* need to add a > >procedural mirror APIs, especially with such auspicious function names as > >datepatterngenerator_get_best_pattern? > > > >I believe the procedural APIs are considered

Re: [PHP-DEV] [VOTE] Add IntlDatePatternGenerator

2021-05-28 Thread Mel Dafert
>It's ... checks calendar ... the year 2021. Do we *really* need to add a >procedural mirror APIs, especially with such auspicious function names as >datepatterngenerator_get_best_pattern? > >I believe the procedural APIs are considered legacy APIs, and we are >intentionally not adding them for new

Re: [PHP-DEV] [VOTE] Add IntlDatePatternGenerator

2021-05-28 Thread Nikita Popov
On Fri, May 14, 2021 at 5:56 PM Mel Dafert wrote: > Hi Internals, > I have opened the vote on > https://wiki.php.net/rfc/intldatetimepatterngenerator. > I will close it on 2021-05-28. > > For previous discussion see https://externals.io/message/113831 and > https://externals.io/message/114124. >

Re: [PHP-DEV] [VOTE] Add IntlDatePatternGenerator

2021-05-28 Thread Mel Dafert
Hi Internals, I am pleased to announce that this RFC has been accepted unanimously. I have closed the vote. Regards, Mel - Original Message - From: "Mel Dafert" To: "internals" Sent: Friday, May 14, 2021 5:56:23 PM Subject: [PHP-DEV] [VOTE] Add IntlDatePatternGenerator Hi Internals, I