Re: [PHP-DEV] [RFC DISCUSSION] Error Storage Behavior

2016-07-21 Thread Fleshgrinder
On 7/13/2016 10:29 PM, Nikita Popov wrote: > I think there is some confusion about this change because the description > was unclear. > > The change is **only** about EH_THROW handling. EH_THROW is used by > extensions to replace warnings etc with exceptions. Currently the exception > is thrown, b

Re: [PHP-DEV] [RFC DISCUSSION] Error Storage Behavior

2016-07-13 Thread Nikita Popov
On Mon, Jun 27, 2016 at 9:53 PM, Stanislav Malyshev wrote: > Hi! > > > Currently error_get_last() always contains the last error that occurred, > > however, this is actually not desired if the last error was an exception > > that was caught. > > > > https://github.com/php/php-src/pull/1936 > > I

Re: [PHP-DEV] [RFC DISCUSSION] Error Storage Behavior

2016-06-28 Thread Fleshgrinder
On 6/27/2016 9:53 PM, Stanislav Malyshev wrote: > Hi! > >> Currently error_get_last() always contains the last error that occurred, >> however, this is actually not desired if the last error was an exception >> that was caught. >> >> https://github.com/php/php-src/pull/1936 > > I think conditioni

Re: [PHP-DEV] [RFC DISCUSSION] Error Storage Behavior

2016-06-27 Thread Stanislav Malyshev
Hi! > Currently error_get_last() always contains the last error that occurred, > however, this is actually not desired if the last error was an exception > that was caught. > > https://github.com/php/php-src/pull/1936 I think conditioning warnings on whether exception is caught or not is a very

Re: [PHP-DEV] [RFC DISCUSSION] Error Storage Behavior

2016-06-26 Thread Dan Ackroyd
On 6/11/2016 5:48 PM, Fleshgrinder wrote: > Currently error_get_last() always contains the last error that occurred, > however, this is actually not desired if the last error was an exception > that was caught. Changing the behaviour of how errors are handled, to depend on what happens after the e

Re: [PHP-DEV] [RFC DISCUSSION] Error Storage Behavior

2016-06-26 Thread Fleshgrinder
On 6/11/2016 5:48 PM, Fleshgrinder wrote: > Currently error_get_last() always contains the last error that occurred, > however, this is actually not desired if the last error was an exception > that was caught. > > https://github.com/php/php-src/pull/1936 > > With the above change only uncaught e