Re: [PHP-DEV] [RFC] foreach_variable supporting T_LIST token

2011-08-22 Thread Xinchen Hui
Hi: I found this feature was decided to do in PHP 5.3 TODO list : http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/TODO?revision=242949&view=markup so I was wondering does this previous decision still shoudl be think as valid? hehe thanks 2011/7/7 Xinchen Hui : > Hi: > >   thanks

Re: [PHP-DEV] [RFC] foreach_variable supporting T_LIST token

2011-07-07 Thread Xinchen Hui
Hi: thanks very much for this, that second patch is a wrong one, updated .. thanks 2011/7/7 Nikita Popov : > +1 for adding this. > > I don't know enough C to review the patches. The first one looks fine though > at first glance (apart from some CS *nits probably, like duplicate > parenthesis

Re: [PHP-DEV] [RFC] foreach_variable supporting T_LIST token

2011-07-07 Thread Nikita Popov
+1 for adding this. I don't know enough C to review the patches. The first one looks fine though at first glance (apart from some CS *nits probably, like duplicate parenthesis and usage of if {} else { if {} else {}} instead of if {} elseif {} else {}). Your second patch (the one for adding the s

Re: [PHP-DEV] [RFC] foreach_variable supporting T_LIST token

2011-07-06 Thread Xinchen Hui
Hi: first of all, I am a guy whose english is poor, sorry for making you confuse. the feature request is here: https://bugs.php.net/bug.php?id=10203 and I think this can make php code more flexible, and more making sense. example: foreach (array( array(3, array(1, 2)), ar

Re: [PHP-DEV] [RFC] foreach_variable supporting T_LIST token

2011-07-06 Thread Stefan Neufeind
Hi, On 07/06/2011 03:06 PM, Hannes Magnusson wrote: > 2011/7/6 Xinchen Hui : >> >> T_LIST is not allowed to used with foreach before. >> >> and then there comes a freature request: #10203 allow >> foreach($array as list($a,$b) > > Ironically enough you managed to miss the last closing ), en

Re: [PHP-DEV] [RFC] foreach_variable supporting T_LIST token

2011-07-06 Thread Hannes Magnusson
2011/7/6 Xinchen Hui : > Hi: > >   T_LIST is not allowed to used with foreach before. > >   and then there comes a freature request:  #10203  allow > foreach($array as list($a,$b) Ironically enough you managed to miss the last closing ), enforcing the point of this not being a natural syntax. Fur