Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-10 Thread Rowan Collins
On 10/01/2016 08:58, Yasuo Ohgaki wrote: - "super_global" rather than "superglobal" to obey CODING_STANDARD. AFAIK, "superglobal" is consistently spelled as one word throughout the manual, so that underscore looks very out of place to me. -- Rowan Collins [IMSoP] -- PHP Internals - PHP R

Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-10 Thread Yasuo Ohgaki
Hi Bishop, On Sat, Jan 2, 2016 at 6:47 AM, Bishop Bettini wrote: > > RFC: https://wiki.php.net/rfc/on_demand_name_mangling I like the idea overall. mangle_superglobals()/name() could be php_mangle_super_global()/name() - "php_" prefix for being explicit it's for PHP, especially mangle_name().

Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-08 Thread Bishop Bettini
On Fri, Jan 8, 2016 at 9:39 AM, Nikita Popov wrote: I still don't like this part: > > > > As written, one can't: the engine emits the error as soon as it mangles > a variable, at most one time per startup. While that's annoying, it's also > informative: someone's hitting your application in a way

Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-08 Thread Nikita Popov
On Mon, Jan 4, 2016 at 5:16 PM, Bishop Bettini wrote: > On Sat, Jan 2, 2016 at 11:45 AM, Rowan Collins > wrote: > >> On 02/01/2016 03:09, Bishop Bettini wrote: >> >>> But, even without a setting, there's an escape hatch: userland can >>> polyfill >>> the mangling behavior using extract. The upd

Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-04 Thread Bishop Bettini
On Sat, Jan 2, 2016 at 11:45 AM, Rowan Collins wrote: > On 02/01/2016 03:09, Bishop Bettini wrote: > >> But, even without a setting, there's an escape hatch: userland can >> polyfill >> the mangling behavior using extract. The updated RFC demonstrates an >> algorithm. >> > > I'm not that comfort

Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-02 Thread Rowan Collins
On 02/01/2016 03:09, Bishop Bettini wrote: But, even without a setting, there's an escape hatch: userland can polyfill the mangling behavior using extract. The updated RFC demonstrates an algorithm. I'm not that comfortable with requiring / encouraging the use of extract() - a rather awkward

Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-01 Thread Bishop Bettini
On Fri, Jan 1, 2016 at 10:23 PM, Stanislav Malyshev wrote: > Hi! > > > Ringing in the new year with a proposal to retool name mangling: > > While the variable name changing probably outlived its usefulness with > the demise of register_globals, changing it would produce serious BC > issues with w

Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-01 Thread Stanislav Malyshev
Hi! > Ringing in the new year with a proposal to retool name mangling: While the variable name changing probably outlived its usefulness with the demise of register_globals, changing it would produce serious BC issues with which we should be very careful. Emitting E_DEPRECATED based on user data

Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-01 Thread Bishop Bettini
On Fri, Jan 1, 2016 at 5:11 PM, Nikita Popov wrote: > On Fri, Jan 1, 2016 at 10:47 PM, Bishop Bettini wrote: > >> Hello Internals, >> >> Ringing in the new year with a proposal to retool name mangling: >> >> Mangling has the undesirable consequence that many external variables may >> map to one

Re: [PHP-DEV] [RFC] On-Demand Name Mangling

2016-01-01 Thread Nikita Popov
On Fri, Jan 1, 2016 at 10:47 PM, Bishop Bettini wrote: > Hello Internals, > > Ringing in the new year with a proposal to retool name mangling: > > Mangling has the undesirable consequence that many external variables may > map to one PHP variable. This leads to user confusion and user-land > work