Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-07-11 Thread Arpad Ray
On Sun, Jul 3, 2011 at 4:15 PM, Felipe Pena wrote: > I like the idea (and voted +1 on it), but I've some consideration to do: > > +/* {{{ proto bool SessionHandler::open(string save_path, string session_name) > +   Wraps the old open handler */ > +PHP_METHOD(SessionHandler, open) > +{ > +       PS

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-07-03 Thread Felipe Pena
Hi, 2011/6/2 Arpad Ray : > Hi, > > A while ago I submitted a patch to allow session_set_save_handler() to > accept a class, and support the inheritance of the default session > handler's methods. > > The RFC has a more detailed description and the current patch: > https://wiki.php.net/rfc/session-

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-27 Thread Larry Garfield
On 6/27/11 11:01 AM, Arpad Ray wrote: On Mon, Jun 27, 2011 at 5:00 PM, Arpad Ray wrote: On Mon, Jun 27, 2011 at 4:52 AM, Larry Garfield wrote: I'm a bit confused. If the session handler goes out of its way to ensure that it's the last thing to run, wouldn't that cause an issue if it tries to

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-27 Thread Arpad Ray
On Mon, Jun 27, 2011 at 5:00 PM, Arpad Ray wrote: > On Mon, Jun 27, 2011 at 4:52 AM, Larry Garfield > wrote: >> I'm a bit confused.  If the session handler goes out of its way to ensure >> that it's the last thing to run, wouldn't that cause an issue if it tries to >> write session data after, s

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-26 Thread Larry Garfield
On 06/25/2011 12:13 AM, Arpad Ray wrote: Hi, I've updated the patches again. The most significant change is that the shutdown function registers another shutdown function when it's called, to (almost) ensure that it's always the last one, and therefore user shutdown functions should always find

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-24 Thread Arpad Ray
On Sat, Jun 25, 2011 at 6:13 AM, Arpad Ray wrote: > The most significant change is that the shutdown function registers > another shutdown function when it's called, to (almost) ensure that > it's always the last one, and therefore user shutdown functions should > always find the session available

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-24 Thread Arpad Ray
Hi, I've updated the patches again. The most significant change is that the shutdown function registers another shutdown function when it's called, to (almost) ensure that it's always the last one, and therefore user shutdown functions should always find the session available as expected. I'd esp

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-20 Thread Arpad Ray
On Mon, Jun 20, 2011 at 10:37 AM, Richard Quadling wrote: > On 20 June 2011 01:39, Arpad Ray wrote: >> On Mon, Jun 6, 2011 at 5:31 PM, Richard Quadling wrote: >>> Not an internals expert, but I do have a question. >>> >>> When would the session handler object be destroyed? >>> >>> If sessions ar

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-20 Thread Richard Quadling
On 20 June 2011 01:39, Arpad Ray wrote: > On Mon, Jun 6, 2011 at 5:31 PM, Richard Quadling wrote: >> Not an internals expert, but I do have a question. >> >> When would the session handler object be destroyed? >> >> If sessions are being logged to a DB (maybe via a userland PHP class), >> is inte

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-19 Thread Arpad Ray
On Mon, Jun 6, 2011 at 5:31 PM, Richard Quadling wrote: > Not an internals expert, but I do have a question. > > When would the session handler object be destroyed? > > If sessions are being logged to a DB (maybe via a userland PHP class), > is internal reference counting enough to handle the orde

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-06 Thread Mike Willbanks
Forgot to keep the list on this one. On Mon, Jun 6, 2011 at 11:19 AM, Mike Willbanks wrote: > A while ago I submitted a patch to allow session_set_save_handler() to >> accept a class, and support the inheritance of the default session >> handler's methods. >> >> The RFC has a more detailed descr

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-06-06 Thread Richard Quadling
On 3 June 2011 02:18, Arpad Ray wrote: > Hi, > > A while ago I submitted a patch to allow session_set_save_handler() to > accept a class, and support the inheritance of the default session > handler's methods. > > The RFC has a more detailed description and the current patch: > https://wiki.php.ne