Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-08 Thread Ferenc Kovacs
On Fri, Feb 8, 2013 at 10:16 PM, Keyur Govande wrote: > On Fri, Feb 8, 2013 at 4:01 PM, Ferenc Kovacs wrote: > >> >> >> >> On Fri, Feb 8, 2013 at 9:30 PM, Keyur Govande wrote: >> >>> On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse >> >wrote: >>> >>> > Hi, >>> > >>> > could you rename these functi

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-08 Thread Keyur Govande
On Fri, Feb 8, 2013 at 4:01 PM, Ferenc Kovacs wrote: > > > > On Fri, Feb 8, 2013 at 9:30 PM, Keyur Govande wrote: > >> On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse > >wrote: >> >> > Hi, >> > >> > could you rename these functions to: >> > >> > cli_process_set_title >> > cli_process_get_title >>

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-08 Thread Ferenc Kovacs
On Fri, Feb 8, 2013 at 9:30 PM, Keyur Govande wrote: > On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse >wrote: > > > Hi, > > > > could you rename these functions to: > > > > cli_process_set_title > > cli_process_get_title > > > > http://www.php.net/manual-**lookup.php?pattern=set_&scope=**quickre

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-08 Thread Keyur Govande
On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse wrote: > Hi, > > could you rename these functions to: > > cli_process_set_title > cli_process_get_title > > http://www.php.net/manual-**lookup.php?pattern=set_&scope=**quickref > gives

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-08 Thread Nikita Popov
On Fri, Feb 8, 2013 at 7:56 AM, Rasmus Lerdorf wrote: > On 02/07/2013 10:25 AM, Nikita Popov wrote: > > On Thu, Feb 7, 2013 at 2:39 PM, Christoph Rosse >wrote: > > > >> why wouldn't this go into core? setting the name of the current > >> php-process is definitely something everyone that develops

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-08 Thread Christoph Rosse
Hi, could you rename these functions to: cli_process_set_title cli_process_get_title http://www.php.net/manual-lookup.php?pattern=set_&scope=quickref gives me a lot of hits like: xml_parser_set_options stream_set_read_buffer pg_set_info ps_set_border_color etc. its also a lot more readable a

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Rasmus Lerdorf
On 02/07/2013 10:25 AM, Nikita Popov wrote: > On Thu, Feb 7, 2013 at 2:39 PM, Christoph Rosse wrote: > >> why wouldn't this go into core? setting the name of the current >> php-process is definitely something everyone that develops php-cli scripts >> could use. >> > I use a lot of php-cli scripts

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Keyur Govande
Addressing a bunch of comments at once: 1) I've removed is_available and renamed the set/get methods to: cli_process_title_set/get. I've also removed the test dependencies on pcntl and posix. The patch is updated: https://gist.github.com/keyurdg/4728770 2) Updated the RFC's introduction section wit

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Nikita Popov
On Thu, Feb 7, 2013 at 2:39 PM, Christoph Rosse wrote: > why wouldn't this go into core? setting the name of the current > php-process is definitely something everyone that develops php-cli scripts > could use. > I use a lot of php-cli scripts and I've never seen the need. Without having hard data

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Christoph Rosse
Am 2013-02-07 14:57, schrieb Christoph Rosse: Am 2013-02-07 14:00, schrieb Alexey Zakhlestin: On 07.02.2013, at 16:33, Leigh wrote: Why does this need to be in core? This could just be done as a set of improvements to the existing PECL extension instead. I'd guess that the number of people w

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Arvids Godjuks
Hello internals. I'm actually using proctitle extension and it's very handy because we run like 10+ daemons written in PHP that we manage. Without it we would be lost :) But the actual awareness of the proctitle PECL extension is very low. Also it does not work on windows. I'm all over the idea to

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Christoph Rosse
Am 2013-02-07 14:00, schrieb Alexey Zakhlestin: On 07.02.2013, at 16:33, Leigh wrote: Why does this need to be in core? This could just be done as a set of improvements to the existing PECL extension instead. I'd guess that the number of people who require (and would use) this functionality

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Christoph Rosse
Am 2013-02-07 13:33, schrieb Leigh: On 7 February 2013 12:22, Alexey Zakhlestin wrote: On 07.02.2013, at 13:54, Leigh wrote: There is a PECL extension that already does something similar. You may want to take a look at that. http://pecl.php.net/package/proctitle Did you read RFC? Keyu

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Alexey Zakhlestin
On 07.02.2013, at 16:33, Leigh wrote: > Why does this need to be in core? This could just be done as a set of > improvements to the existing PECL extension instead. I'd guess that the > number of people who require (and would use) this functionality is very very > small indeed. well, 2 reaso

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Michael Wallner
On 7 February 2013 13:33, Leigh wrote: > On 7 February 2013 12:22, Alexey Zakhlestin wrote: > >> >> On 07.02.2013, at 13:54, Leigh wrote: >> >> > There is a PECL extension that already does something similar. You may >> want >> > to take a look at that. >> > >> > http://pecl.php.net/package/proc

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Leigh
On 7 February 2013 12:22, Alexey Zakhlestin wrote: > > On 07.02.2013, at 13:54, Leigh wrote: > > > There is a PECL extension that already does something similar. You may > want > > to take a look at that. > > > > http://pecl.php.net/package/proctitle > > Did you read RFC? > Keyur mentions it and

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Alexey Zakhlestin
On 07.02.2013, at 13:54, Leigh wrote: > There is a PECL extension that already does something similar. You may want > to take a look at that. > > http://pecl.php.net/package/proctitle Did you read RFC? Keyur mentions it and its limitations there -- Alexey Zakhlestin https://github.com/indey

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Leigh
There is a PECL extension that already does something similar. You may want to take a look at that. http://pecl.php.net/package/proctitle On 7 February 2013 05:40, Keyur Govande wrote: > Hello, > > I've created a new RFC to improve support for setting a CLI process' title > on Linux. It is bas

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Michael Wallner
On 7 February 2013 09:37, Christoph Rosse wrote: > Am 2013-02-07 08:45, schrieb Alexey Zakhlestin: > >> >> On 07.02.2013, at 9:40, Keyur Govande wrote: >> >>> Hello, >>> >>> I've created a new RFC to improve support for setting a CLI process' >>> title >>> on Linux. It is based off of the Postgre

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Christoph Rosse
Am 2013-02-07 08:45, schrieb Alexey Zakhlestin: On 07.02.2013, at 9:40, Keyur Govande wrote: Hello, I've created a new RFC to improve support for setting a CLI process' title on Linux. It is based off of the PostgreSQL implementation and is more robust than the proctitle extension. More det

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Ivan Enderlin @ Hoa
Hi Keyur, On 07/02/13 06:40, Keyur Govande wrote: Hello, I've created a new RFC to improve support for setting a CLI process' title on Linux. It is based off of the PostgreSQL implementation and is more robust than the proctitle extension. More details and patch here: https://wiki.php.net/rfc

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-06 Thread Nikita Popov
On Thu, Feb 7, 2013 at 6:40 AM, Keyur Govande wrote: > Hello, > > I've created a new RFC to improve support for setting a CLI process' title > on Linux. It is based off of the PostgreSQL implementation and is more > robust than the proctitle extension. > > More details and patch here: https://wiki

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-06 Thread Alexey Zakhlestin
On 07.02.2013, at 9:40, Keyur Govande wrote: > Hello, > > I've created a new RFC to improve support for setting a CLI process' title > on Linux. It is based off of the PostgreSQL implementation and is more > robust than the proctitle extension. > > More details and patch here: https://wiki.php