Re: [PHP-DEV] [RFC] E_NOTICE for invalid array container

2016-08-08 Thread David Walker
All, I updated the RFC, and made a couple updates to tests where this notice is raising itself (fpm & mysqli). I ended up catching a couple of oddities in how mine (and previous proposed) changes would have impacted a foreach(list() = each()), so it won't raise a warning on the last, null, elemen

Re: [PHP-DEV] [RFC] E_NOTICE for invalid array container

2016-08-02 Thread David Walker
Dan, You're right on both accounts; also, as I just notices it could easily have other BC-breaks (although expecting errors in a certain format is odd) through calls like error_get_last(), which would regardless of INI settings include this NOTICE. I will update the RFC with these changes. -- Da

Re: [PHP-DEV] [RFC] E_NOTICE for invalid array container

2016-08-01 Thread Dan Ackroyd
Hi David, The updated section still doesn't really describe the BC break that well. Some people will need to change their code to avoid having notices raised frequently. How difficult that will be needs to be thought about. Additionally, although the default ini files may turn off notices in pro

Re: [PHP-DEV] [RFC] E_NOTICE for invalid array container

2016-08-01 Thread David Walker
Hi Dan, I left it blank to go along with default production ini-settings where notices would be excluded. However, you are probably correct that it should be noted for development environments as something new. I'll toss it in there in the morning Thanks -- Dave On Mon, Aug 1, 2016 at 01:14 Dan A

Re: [PHP-DEV] [RFC] E_NOTICE for invalid array container

2016-08-01 Thread Dan Ackroyd
Hi David, On 31 July 2016 at 20:31, David Walker wrote: > So I want to solicit for more discussion given previous talks. My > first-attempt RFC for this is at: > https://wiki.php.net/rfc/notice-for-non-valid-array-container > I've very likely to support this RFC, however the section on 'Backwar

Re: [PHP-DEV] [RFC] E_NOTICE for invalid array container

2016-07-31 Thread Niklas Keller
2016-07-31 21:31 GMT+02:00 David Walker : > Hi All, > > I'm attempting to get involved and hack away at some internals; I figured > the best method to do this would be to pick up a bug and do my best at it. > So I grabbed #37676. The issue asks to implement an E_(NOTICE|WARNING) > when attempting