Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-10 Thread Stanislav Malyshev
Hi! > the wall. By deciding not to include this in PHP 7.3, we are essentially > making an implicit decision that PHP 7.4 is going to be a relatively > ordinary feature release rather than a deprecation-only one. (Which is fine > by me really, I don't like the idea of a release that's all stick an

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-10 Thread Nikita Popov
On Tue, Jul 10, 2018 at 12:35 PM, Christoph M. Becker wrote: > On 10.07.2018 at 09:36, Nikita Popov wrote: > > > To make sure there are no unreasonable expectations involved in this > > decision: If this feature will not go into PHP 7.3, then it will in all > > likelihood go into PHP 7.4 instead.

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-10 Thread Christoph M. Becker
On 10.07.2018 at 09:36, Nikita Popov wrote: > To make sure there are no unreasonable expectations involved in this > decision: If this feature will not go into PHP 7.3, then it will in all > likelihood go into PHP 7.4 instead. I think I can safely say not just on > behalf on Bob and myself, but al

RE: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-10 Thread Zeev Suraski
an to force words into your mouth. Zeev -Original Message- From: Zeev Suraski [mailto:vsura...@gmail.com] Sent: Tuesday, July 10, 2018 11:05 AM To: Nikita Popov Cc: Sara Golemon ; Christoph M. Becker ; Kalle Sommer Nielsen ; Internals Subject: Re: [PHP-DEV] [RFC] Deprecations for PH

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-10 Thread Zeev Suraski
ent: Monday, July 9, 2018 5:41 PM >> > To: Christoph M. Becker >> > Cc: Nikita Popov ; Kalle Sommer Nielsen >> > ; Internals >> > Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3 >> > >> > On Sun, Jul 8, 2018 at 5:41 PM, Christoph M. Beck

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-10 Thread Nikita Popov
t; Cc: Nikita Popov ; Kalle Sommer Nielsen > > ; Internals > > Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3 > > > > On Sun, Jul 8, 2018 at 5:41 PM, Christoph M. Becker > > wrote: > > > Sorry, that there has not been any decision yet. However, Sara > > >

RE: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-09 Thread Zeev Suraski
> -Original Message- > From: p...@golemon.com [mailto:p...@golemon.com] On Behalf Of Sara > Golemon > Sent: Monday, July 9, 2018 5:41 PM > To: Christoph M. Becker > Cc: Nikita Popov ; Kalle Sommer Nielsen > ; Internals > Subject: Re: [PHP-DEV] [RFC] Deprecat

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-09 Thread Kalle Sommer Nielsen
Den man. 9. jul. 2018 kl. 21.22 skrev David Zuelke : > Keep in mind you can do phpversion("extensionname"), so that function > at least can't be removed, as the constant doesn't provide the same > functionality. Sure, but almost all of the core extensions return PHP_VERSION anyway (thanks to Peter

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-09 Thread David Zuelke
On Tue, Jun 26, 2018 at 6:32 PM Kalle Sommer Nielsen wrote: > > Hi > > Den søn. 24. jun. 2018 kl. 18.47 skrev Nikita Popov : > > If you have a minor deprecation in mind, but were too lazy to write an RFC > > for it, please write me a mail until tomorrow, so that it might be included > > as part of

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-09 Thread Christoph M. Becker
On 09.07.2018 at 16:40, Sara Golemon wrote: > On Sun, Jul 8, 2018 at 5:41 PM, Christoph M. Becker wrote: > >> Sorry, that there has not been any decision yet. However, Sara >> suggested that this decision is not solely up to the RMs[1], and I >> wouldn't know how to decide it then[2], since ther

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-09 Thread Sara Golemon
On Sun, Jul 8, 2018 at 5:41 PM, Christoph M. Becker wrote: > Sorry, that there has not been any decision yet. However, Sara > suggested that this decision is not solely up to the RMs[1], and I > wouldn't know how to decide it then[2], since there has been at least > one objection[3]. > To clarify

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-08 Thread Kalle Sommer Nielsen
Den søn. 8. jul. 2018 kl. 23.42 skrev Christoph M. Becker : > Sorry, that there has not been any decision yet. However, Sara > suggested that this decision is not solely up to the RMs[1], and I > wouldn't know how to decide it then[2], since there has been at least > one objection[3]. > > [1]

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-08 Thread Kalle Sommer Nielsen
Den søn. 8. jul. 2018 kl. 23.18 skrev Nikita Popov : > I assume that we're going forward with the addition of the alias, so I moved > the FILTER_SANITIZE_MAGIC_QUOTES deprecation from the PHP 7.3 to the PHP 7.4 > deprecations RFC. I implemented the 'add_slashes' filter to master so we should all

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-08 Thread Christoph M. Becker
On 08.07.2018 at 23:18, Nikita Popov wrote: > I'll start the vote on this RFC (and the case-insensitive constants RFC) > tomorrow, with a duration of one week. I was holding off on these votes > because earlier comments in the typed references RFC thread made it appear > like a change to the relea

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-08 Thread Nikita Popov
On Fri, Jul 6, 2018 at 6:50 AM, Kalle Sommer Nielsen wrote: > Den tor. 5. jul. 2018 kl. 22.51 skrev Kalle Sommer Nielsen >: > > > > Den tor. 5. jul. 2018 kl. 22.46 skrev Nikita Popov >: > > > Sounds reasonable to me. My only question would be when we would start > emitting the deprecation notic

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-05 Thread Kalle Sommer Nielsen
Den tor. 5. jul. 2018 kl. 22.51 skrev Kalle Sommer Nielsen : > > Den tor. 5. jul. 2018 kl. 22.46 skrev Nikita Popov : > > Sounds reasonable to me. My only question would be when we would start > > emitting the deprecation notice. I'm not a fan of deprecating things in the > > same release as the

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-05 Thread Kalle Sommer Nielsen
Den tor. 5. jul. 2018 kl. 22.46 skrev Nikita Popov : > Sounds reasonable to me. My only question would be when we would start > emitting the deprecation notice. I'm not a fan of deprecating things in the > same release as the alternative is introduced, so I would suggest to add the > new alias i

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-05 Thread Nikita Popov
On Thu, Jul 5, 2018 at 10:42 PM, Kalle Sommer Nielsen wrote: > Den tor. 5. jul. 2018 kl. 22.22 skrev Stanislav Malyshev < > smalys...@gmail.com>: > > > > Hi! > > > > > After looking into this, I think that FILTER_SANITIZE_MAGIC_QUOTES may > be a > > > legitimate filter, which just has a bad name.

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-05 Thread Kalle Sommer Nielsen
Den tor. 5. jul. 2018 kl. 22.22 skrev Stanislav Malyshev : > > Hi! > > > After looking into this, I think that FILTER_SANITIZE_MAGIC_QUOTES may be a > > legitimate filter, which just has a bad name. Next to other filters that > > perform htmlspecialchars and urlencode, it makes sense that there is

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-05 Thread Stanislav Malyshev
Hi! > After looking into this, I think that FILTER_SANITIZE_MAGIC_QUOTES may be a > legitimate filter, which just has a bad name. Next to other filters that > perform htmlspecialchars and urlencode, it makes sense that there is also a > filter that performs addslashes. Maybe we should just rename

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-05 Thread Nikita Popov
On Tue, Jun 26, 2018 at 10:22 PM, Kalle Sommer Nielsen wrote: > Den søn. 24. jun. 2018 kl. 18.47 skrev Nikita Popov >: > > If you have a minor deprecation in mind, but were too lazy to write an > RFC > > for it, please write me a mail until tomorrow, so that it might be > included > > as part of

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-07-05 Thread Nikita Popov
On Mon, Jun 25, 2018 at 9:32 PM, Sara Golemon wrote: > On Sun, Jun 24, 2018 at 11:47 AM, Nikita Popov > wrote: > > https://wiki.php.net/rfc/deprecations_php_7_3 > > > > Undocumented mbstring function aliases > > > Yeah, if they're just dumb aliases, then it's a slight gain to narrow > the symbol

RE: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Zeev Suraski
of items to discuss at a future time..? Zeev > -Original Message- > From: Stanislav Malyshev [mailto:smalys...@gmail.com] > Sent: Wednesday, June 27, 2018 3:39 AM > To: Kalle Sommer Nielsen ; Nikita Popov > > Cc: Internals > Subject: Re: [PHP-DEV] [RFC] Dep

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Stanislav Malyshev
Hi! > - The (real) type-cast and its function, is_real(). There doesn't > seem to be any support for reals in settype() anyway (side note: in > the implementation of settype() it claims "double" is deprecated) > - Function variants that already exists as constants, php_sapi_name() >> PHP_SAPI, p

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Kalle Sommer Nielsen
Den søn. 24. jun. 2018 kl. 18.47 skrev Nikita Popov : > If you have a minor deprecation in mind, but were too lazy to write an RFC > for it, please write me a mail until tomorrow, so that it might be included > as part of this proposal. As time is limited I don't want to include > anything larger o

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Kalle Sommer Nielsen
Den tir. 26. jun. 2018 kl. 22.01 skrev Nikita Popov : > Thanks for adding it. Unless there is a particular reason to rush here, I'd > suggest to follow the usual process and formally deprecate the option prior > to removal. I don't think theres a need for a rush here, tho I wasn't sure how you p

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Nikita Popov
On Tue, Jun 26, 2018 at 9:51 PM, Kalle Sommer Nielsen wrote: > Den tir. 26. jun. 2018 kl. 20.16 skrev Nikita Popov >: > > Feel free to add this one to the RFC, if you know what the background > for the deprecation is. Given that the manual already marks it as > deprecated for so long, this seems

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Kalle Sommer Nielsen
Den tir. 26. jun. 2018 kl. 20.16 skrev Nikita Popov : > Feel free to add this one to the RFC, if you know what the background for the > deprecation is. Given that the manual already marks it as deprecated for so > long, this seems like a mere technicality. I added the pdo_odbc.db2_instance_name

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Nikita Popov
On Mon, Jun 25, 2018 at 9:32 PM, Sara Golemon wrote: > On Sun, Jun 24, 2018 at 11:47 AM, Nikita Popov > wrote: > > https://wiki.php.net/rfc/deprecations_php_7_3 > > > > Undocumented mbstring function aliases > > > Yeah, if they're just dumb aliases, then it's a slight gain to narrow > the symbol

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Nikita Popov
On Tue, Jun 26, 2018 at 6:31 PM, Kalle Sommer Nielsen wrote: > Hi > > Den søn. 24. jun. 2018 kl. 18.47 skrev Nikita Popov >: > > If you have a minor deprecation in mind, but were too lazy to write an > RFC > > for it, please write me a mail until tomorrow, so that it might be > included > > as p

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Kalle Sommer Nielsen
Hi Den søn. 24. jun. 2018 kl. 18.47 skrev Nikita Popov : > If you have a minor deprecation in mind, but were too lazy to write an RFC > for it, please write me a mail until tomorrow, so that it might be included > as part of this proposal. As time is limited I don't want to include > anything larg

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Nicolas Grekas
> https://wiki.php.net/rfc/deprecations_php_7_3 > Do you think we could ass Serializable to the list? See your own arguments in https://externals.io/message/98834 :) Nicolas

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-26 Thread Marco Pivetta
On Mon, Jun 25, 2018 at 9:32 PM, Sara Golemon wrote: > > Defining a free-standing assert() function > > > Eww, yeah. I can see that problem. I'm not a huge fan of banning all > namespaced assert() function declarations, but it's certainly the most > direct "solution" to the problem. A very quic

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-25 Thread Sara Golemon
On Sun, Jun 24, 2018 at 11:47 AM, Nikita Popov wrote: > https://wiki.php.net/rfc/deprecations_php_7_3 > > Undocumented mbstring function aliases > Yeah, if they're just dumb aliases, then it's a slight gain to narrow the symbol table by removing duplicates. A modest composer package (nay, include

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-25 Thread Stanislav Malyshev
Hi! > There are multiple bug reports regarding strip_tags()'s broken behavior > on (slightly) malformed HTML, e.g. , > and , which > renders the function unusable on arbitrary user supplied input. I see a very co

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-25 Thread Christoph M. Becker
On 25.06.2018 at 08:12, Stanislav Malyshev wrote: >> fgetss() function and string.strip_tags filter > > I think I disagree with "strip_tags() itself, due to its limitations and > known bugs, already has very few legitimate applications" and certainly > the manual does not have any notice to that

Re: [PHP-DEV] [RFC] Deprecations for PHP 7.3

2018-06-24 Thread Stanislav Malyshev
Hi! > This RFC collects a number of deprecations for PHP 7.3 which I consider to > be too minor to warrant a separate proposal. However, each deprecation will > still be voted separately. > > https://wiki.php.net/rfc/deprecations_php_7_3 > Undocumented mbstring function aliases Not sure what th